aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLoek Le Blansch <loek@pipeframe.xyz>2024-12-04 14:21:26 +0100
committerLoek Le Blansch <loek@pipeframe.xyz>2024-12-04 14:21:26 +0100
commitcfb67ffddb9f4bb0357c2b9df4239bfee7364c5a (patch)
treee072a36db5c9f1a75332d23f76a986d0d2215718 /src
parentac7cc7d5c5815ee75b58a3b5ceff747ab99015ed (diff)
process PR feedback
Diffstat (limited to 'src')
-rw-r--r--src/crepe/api/BehaviorScript.hpp10
-rw-r--r--src/crepe/manager/Manager.h8
-rw-r--r--src/crepe/system/System.h5
3 files changed, 14 insertions, 9 deletions
diff --git a/src/crepe/api/BehaviorScript.hpp b/src/crepe/api/BehaviorScript.hpp
index 6de0157..b9bb1e2 100644
--- a/src/crepe/api/BehaviorScript.hpp
+++ b/src/crepe/api/BehaviorScript.hpp
@@ -13,14 +13,12 @@ template <class T, typename... Args>
BehaviorScript & BehaviorScript::set_script(Args &&... args) {
dbg_trace();
static_assert(std::is_base_of<Script, T>::value);
- Script * s = new T(std::forward<Args>(args)...);
- Mediator & mediator = this->mediator;
+ this->script = std::unique_ptr<Script>(new T(std::forward<Args>(args)...));
- s->game_object_id = this->game_object_id;
- s->active = this->active;
- s->mediator = mediator;
+ this->script->game_object_id = this->game_object_id;
+ this->script->active = this->active;
+ this->script->mediator = this->mediator;
- this->script = std::unique_ptr<Script>(s);
return *this;
}
diff --git a/src/crepe/manager/Manager.h b/src/crepe/manager/Manager.h
index 4f21ef4..84d80fe 100644
--- a/src/crepe/manager/Manager.h
+++ b/src/crepe/manager/Manager.h
@@ -4,6 +4,14 @@
namespace crepe {
+/**
+ * \brief Base manager class
+ *
+ * Managers are used for various tasks that fall outside the ECS system category. All managers
+ * are required to register themselves to the mediator passed to the constructor, and this
+ * mutable reference is saved for convenience, even though not all managers use the mediator
+ * directly.
+ */
class Manager {
public:
Manager(Mediator & mediator);
diff --git a/src/crepe/system/System.h b/src/crepe/system/System.h
index 4e7fc6d..063dfbf 100644
--- a/src/crepe/system/System.h
+++ b/src/crepe/system/System.h
@@ -9,9 +9,8 @@ class ComponentManager;
/**
* \brief Base ECS system class
*
- * This class is used as the base for all system classes. Classes derived from
- * System must implement the System::update() method and copy Script::Script
- * with the `using`-syntax.
+ * This class is used as the base for all system classes. Classes derived from System must
+ * implement the System::update() method and copy Script::Script with the `using`-syntax.
*/
class System {
public: