Eslint rule updates (#673)

* Install unicorn

* Add rules

* Fix issues

* Install sonarjs

* Set up rules

* Fix issues

* Install eslint-plugin-import and fix import extensions

* Simplify permitted error names

1 files changed, 6 insertions, 6 deletions

diff --git a/ext/js/language/translator.js b/ext/js/language/translator.js
index 007a7d1e..2ba1ce0d 100644
--- a/ext/js/language/translator.js
+++ b/ext/js/language/translator.js
@@ -491,11 +491,11 @@ export class Translator {
      * @returns {number}
      */
     _getNextSubstringLength(searchResolution, currentLength, source) {
-        if (searchResolution === 'word') {
-            return source.search(/[^\p{Letter}][\p{Letter}\p{Number}]*$/u);
-        } else {
-            return currentLength - 1;
-        }
+        return (
+            searchResolution === 'word' ?
+            source.search(/[^\p{Letter}][\p{Letter}\p{Number}]*$/u) :
+            currentLength - 1
+        );
     }
 
     /**
@@ -620,7 +620,7 @@ export class Translator {
             for (const group of groupedDictionaryEntries) {
                 this._sortTermDictionaryEntriesById(group.dictionaryEntries);
             }
-            if (ungroupedDictionaryEntriesMap.size !== 0 || secondarySearchDictionaryMap.size !== 0) {
+            if (ungroupedDictionaryEntriesMap.size > 0 || secondarySearchDictionaryMap.size > 0) {
                 await this._addSecondaryRelatedDictionaryEntries(groupedDictionaryEntries, ungroupedDictionaryEntriesMap, enabledDictionaryMap, secondarySearchDictionaryMap, tagAggregator);
             }
         }