Improve note addability (#1440)

* Add valid field

* Add isNoteDataValid function

* Update _areDefinitionsAddableForcedValue to return proper valid values

* Refactor isAnkiConnected check

* Force canAdd to false if not valid

1 files changed, 15 insertions, 0 deletions

diff --git a/ext/js/data/anki-util.js b/ext/js/data/anki-util.js
index fc081ddc..c815ccc7 100644
--- a/ext/js/data/anki-util.js
+++ b/ext/js/data/anki-util.js
@@ -81,6 +81,21 @@ class AnkiUtil {
     static cloneFieldMarkerPattern(global) {
         return new RegExp(this._markerPattern.source, global ? 'g' : '');
     }
+
+    /**
+     * Checks whether or not a note object is valid.
+     * @param note A note object to check.
+     * @return `true` if the note is valid, `false` otherwise.
+     */
+    static isNoteDataValid(note) {
+        if (!isObject(note)) { return false; }
+        const {fields, deckName, modelName} = note;
+        return (
+            typeof deckName === 'string' &&
+            typeof modelName === 'string' &&
+            Object.entries(fields).length > 0
+        );
+    }
 }
 
 // eslint-disable-next-line no-underscore-dangle