diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2020-12-19 15:42:44 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-19 15:42:44 -0500 |
| commit | 1b1b24ab35f80ee22ddbdc2172a25b9442bd5dce (patch) | |
| tree | bddbffb9fcb1dac9ceece71e69dc916e3e0c0ae8 /ext/bg | |
| parent | dcb75cce1e3590b4f1469c01a721e3ef3b319888 (diff) | |
Entry indicator update (#1134)
* Move entry current indicator rules
* Simplify rules
* Add popupCurrentIndicatorMode option
* Add option to settings page
* Expose popupCurrentIndicatorMode
* Restore asterisk current indicator
* Implement dot
* Update action button vars
* Fix tests
* Add none option
* Add triangle option
Diffstat (limited to 'ext/bg')
| -rw-r--r-- | ext/bg/data/options-schema.json | 8 | ||||
| -rw-r--r-- | ext/bg/js/options.js | 2 | ||||
| -rw-r--r-- | ext/bg/settings2.html | 19 |
3 files changed, 28 insertions, 1 deletions
diff --git a/ext/bg/data/options-schema.json b/ext/bg/data/options-schema.json index 85275952..b6b11b66 100644 --- a/ext/bg/data/options-schema.json +++ b/ext/bg/data/options-schema.json @@ -109,7 +109,8 @@ "useSecurePopupFrameUrl", "usePopupShadowDom", "usePopupWindow", - "maximumClipboardSearchLength" + "maximumClipboardSearchLength", + "popupCurrentIndicatorMode" ], "properties": { "enable": { @@ -265,6 +266,11 @@ "type": "integer", "default": 1000, "minimum": 0 + }, + "popupCurrentIndicatorMode": { + "type": "string", + "enum": ["none", "asterisk", "triangle", "bar-left", "bar-right", "dot-left", "dot-right"], + "default": "bar-left" } } }, diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js index 876079dc..5492b97d 100644 --- a/ext/bg/js/options.js +++ b/ext/bg/js/options.js @@ -662,8 +662,10 @@ class OptionsUtil { _updateVersion7(options) { // Version 7 changes: // Added general.maximumClipboardSearchLength. + // Added general.popupCurrentIndicatorMode. for (const profile of options.profiles) { profile.options.general.maximumClipboardSearchLength = 1000; + profile.options.general.popupCurrentIndicatorMode = 'bar-left'; } return options; } diff --git a/ext/bg/settings2.html b/ext/bg/settings2.html index b5846c80..bbd75c7f 100644 --- a/ext/bg/settings2.html +++ b/ext/bg/settings2.html @@ -477,6 +477,25 @@ </div> </div></div> <div class="settings-item advanced-only"> + <div class="settings-item-inner settings-item-inner-wrappable"> + <div class="settings-item-left"> + <div class="settings-item-label">Selection indicator style</div> + <div class="settings-item-description">Change how the selected definition entry is visually indicated.</div> + </div> + <div class="settings-item-right"> + <select data-setting="general.popupCurrentIndicatorMode"> + <option value="none">None</option> + <option value="asterisk">Asterisk</option> + <option value="triangle">Triangle</option> + <option value="bar-left">Vertical bar (left)</option> + <option value="bar-right">Vertical bar (right)</option> + <option value="dot-left">Small dot (left)</option> + <option value="dot-right">Small dot (right)</option> + </select> + </div> + </div> + </div> + <div class="settings-item advanced-only"> <div class="settings-item-inner"> <div class="settings-item-left"> <div class="settings-item-label"> |