From 1b1b24ab35f80ee22ddbdc2172a25b9442bd5dce Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Sat, 19 Dec 2020 15:42:44 -0500
Subject: Entry indicator update (#1134)

* Move entry current indicator rules

* Simplify rules

* Add popupCurrentIndicatorMode option

* Add option to settings page

* Expose popupCurrentIndicatorMode

* Restore asterisk current indicator

* Implement dot

* Update action button vars

* Fix tests

* Add none option

* Add triangle option
---
 ext/bg/data/options-schema.json |  8 +++++++-
 ext/bg/js/options.js            |  2 ++
 ext/bg/settings2.html           | 19 +++++++++++++++++++
 3 files changed, 28 insertions(+), 1 deletion(-)

(limited to 'ext/bg')

diff --git a/ext/bg/data/options-schema.json b/ext/bg/data/options-schema.json
index 85275952..b6b11b66 100644
--- a/ext/bg/data/options-schema.json
+++ b/ext/bg/data/options-schema.json
@@ -109,7 +109,8 @@
                                     "useSecurePopupFrameUrl",
                                     "usePopupShadowDom",
                                     "usePopupWindow",
-                                    "maximumClipboardSearchLength"
+                                    "maximumClipboardSearchLength",
+                                    "popupCurrentIndicatorMode"
                                 ],
                                 "properties": {
                                     "enable": {
@@ -265,6 +266,11 @@
                                         "type": "integer",
                                         "default": 1000,
                                         "minimum": 0
+                                    },
+                                    "popupCurrentIndicatorMode": {
+                                        "type": "string",
+                                        "enum": ["none", "asterisk", "triangle", "bar-left", "bar-right", "dot-left", "dot-right"],
+                                        "default": "bar-left"
                                     }
                                 }
                             },
diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js
index 876079dc..5492b97d 100644
--- a/ext/bg/js/options.js
+++ b/ext/bg/js/options.js
@@ -662,8 +662,10 @@ class OptionsUtil {
     _updateVersion7(options) {
         // Version 7 changes:
         //  Added general.maximumClipboardSearchLength.
+        //  Added general.popupCurrentIndicatorMode.
         for (const profile of options.profiles) {
             profile.options.general.maximumClipboardSearchLength = 1000;
+            profile.options.general.popupCurrentIndicatorMode = 'bar-left';
         }
         return options;
     }
diff --git a/ext/bg/settings2.html b/ext/bg/settings2.html
index b5846c80..bbd75c7f 100644
--- a/ext/bg/settings2.html
+++ b/ext/bg/settings2.html
@@ -476,6 +476,25 @@
                 <label class="toggle"><input type="checkbox" data-setting="general.debugInfo"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
             </div>
         </div></div>
+        <div class="settings-item advanced-only">
+            <div class="settings-item-inner settings-item-inner-wrappable">
+                <div class="settings-item-left">
+                    <div class="settings-item-label">Selection indicator style</div>
+                    <div class="settings-item-description">Change how the selected definition entry is visually indicated.</div>
+                </div>
+                <div class="settings-item-right">
+                    <select data-setting="general.popupCurrentIndicatorMode">
+                        <option value="none">None</option>
+                        <option value="asterisk">Asterisk</option>
+                        <option value="triangle">Triangle</option>
+                        <option value="bar-left">Vertical bar (left)</option>
+                        <option value="bar-right">Vertical bar (right)</option>
+                        <option value="dot-left">Small dot (left)</option>
+                        <option value="dot-right">Small dot (right)</option>
+                    </select>
+                </div>
+            </div>
+        </div>
         <div class="settings-item advanced-only">
             <div class="settings-item-inner">
                 <div class="settings-item-left">
-- 
cgit v1.2.3