Reduce code stink (#1818)

CRC32.cpp:
Make table initialization compile time

DSi_NAND.cpp:
Fix file close / unmount / disk close on error
~L427: Remove redundant calls, as they are immediately rendered useless by `rem` being overwritten

NDS.cpp / FreeBIOS.h:
Remove unneeded size values in header
Remove unneeded memset's as they are initialized anyway

sha1.c / sha1.h:
Fix useless warning

Wifi.cpp:
Remove unneeded includes

DSi.cpp:
Reduce ugly casts
Deduplicate code

qt_sdl/main.cpp:
silence clang switch statement warning

qt_sdl/main.h:
fix override warnings

dolphin/BitSet.h:
use msvc extensions only when appropriate, fix broken bit set count under _WIN32

1 files changed, 2 insertions, 2 deletions

diff --git a/src/NDSCart.cpp b/src/NDSCart.cpp
index cda0bf4..f1598eb 100644
--- a/src/NDSCart.cpp
+++ b/src/NDSCart.cpp
@@ -1539,7 +1539,7 @@ void DoSavestate(Savestate* file)
 bool ReadROMParams(u32 gamecode, ROMListEntry* params)
 {
     u32 offset = 0;
-    u32 chk_size = ROMListSize >> 1;
+    u32 chk_size = ROMListEntryCount >> 1;
     for (;;)
     {
         u32 key = 0;
@@ -1568,7 +1568,7 @@ bool ReadROMParams(u32 gamecode, ROMListEntry* params)
             chk_size >>= 1;
         }
 
-        if (offset >= ROMListSize)
+        if (offset >= ROMListEntryCount)
         {
             return false;
         }