From 10d4665466689918eed07d9edd6e38c6183d93e3 Mon Sep 17 00:00:00 2001
From: Loek Le Blansch <loek@pipeframe.xyz>
Date: Wed, 21 Aug 2024 19:29:47 +0200
Subject: more dissector for user join packets

---
 docs/notes.md | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

(limited to 'docs')

diff --git a/docs/notes.md b/docs/notes.md
index 3473ee4..204ac57 100644
--- a/docs/notes.md
+++ b/docs/notes.md
@@ -221,7 +221,9 @@ no idea why this happens.
 
 #### Analysis
 
-![](../assets/ws-msg-fill-mid.png)
+See [the wireshark dissector](../wireshark/pictochat.lua)
+
+<!-- ![](../assets/ws-msg-fill-mid.png)
 
 |offset|type|description|
 |-|-|-|
@@ -232,7 +234,7 @@ no idea why this happens.
 |0x10|`u64`|Ni-Fi: Timestamp|
 |
 |0x18|`u16`|PictoChat: Message type??? (0)|
-|0x1a|`u16`|PictoChat: Resend (2=New, 0=Resend)|<!-- I assume u16 because the next byte is always 0x00 -->
+|0x1a|`u16`|PictoChat: Resend (2=New, 0=Resend)|< !-- I assume u16 because the next byte is always 0x00 -- >
 |0x22|`u16`|PictoChat: Length (offset 36 of complete packet length)|
 |0x28|`u8[6]`|PictoChat: multiplayer CMD MAC (melonDS Wifi::MPCmdMAC)|
 |0x2e|`u8[6]`|PictoChat: sender MAC|
@@ -244,7 +246,6 @@ no idea why this happens.
 |0xf0|`u16`|PictoChat: copy of 0x1a (Resend)|
 |0xf2|`u32`|Unknown: constant 0x93ffb8b6|
 
-<!--
 TODO: 0x4e(PictoChat msg data offset) - 0x18(Ni-Fi header length) == 0x36
 -->
 
@@ -323,4 +324,5 @@ messages from the system that joined later)
     * palette color indices (pixels are 1 nibble)
 - what types of pictochat packets are there? (i.e. how are room join/leave
   events broadcast?)
+- `pictochat.msg_type in {10, 24, 86}` message reassembly in dissector
 
-- 
cgit v1.2.3