From d582c7a0f856c1a352992e3d16be319a891e0202 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Sat, 15 Aug 2020 17:23:09 -0400 Subject: JSON schema refactor (#731) * Remove JsonSchema.clone * Move createProxy function * Group public properties first * Create private version of getPropertySchema * Mark functions as private * Use non-static getValidValueOrDefault * Mark private * Make public validate function not take an info parameter * Remove JsonSchema * Add isValid function * Use isValid for some tests * Fix incorrect type --- test/test-schema.js | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) (limited to 'test/test-schema.js') diff --git a/test/test-schema.js b/test/test-schema.js index b3544b28..a4a0de2e 100644 --- a/test/test-schema.js +++ b/test/test-schema.js @@ -24,7 +24,7 @@ vm.execute([ 'mixed/js/cache-map.js', 'bg/js/json-schema.js' ]); -const JsonSchema = vm.get('JsonSchema'); +const JsonSchemaValidator = vm.get('JsonSchemaValidator'); function testValidate1() { @@ -54,12 +54,7 @@ function testValidate1() { }; const schemaValidate = (value) => { - try { - JsonSchema.validate(value, schema); - return true; - } catch (e) { - return false; - } + return new JsonSchemaValidator().isValid(value, schema); }; const jsValidate = (value) => { @@ -395,12 +390,7 @@ function testValidate2() { ]; const schemaValidate = (value, schema) => { - try { - JsonSchema.validate(value, schema); - return true; - } catch (e) { - return false; - } + return new JsonSchemaValidator().isValid(value, schema); }; for (const {schema, inputs} of data) { @@ -555,7 +545,7 @@ function testGetValidValueOrDefault1() { for (const {schema, inputs} of data) { for (const [value, expected] of inputs) { - const actual = JsonSchema.getValidValueOrDefault(schema, value); + const actual = new JsonSchemaValidator().getValidValueOrDefault(schema, value); vm.assert.deepStrictEqual(actual, expected); } } -- cgit v1.2.3