From d4381831209dfbbbddd6d238c68461c9601573e2 Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Thu, 8 Feb 2024 06:52:06 -0500
Subject: Update eslint (#638)

* Add json test

* Update vscode settings to better handle json

* Collapse eslint rules for easier readability

* Reorganize

* Update no-multi-spaces rule for JSON

* Rules updates

* Switch to @stylistic/eslint-plugin

* Update deprecated stylistic rules

* Group stylistic rules

* Simplify rules

* Move eslint env overrides to end of file

* Add test

* Move promiseAnimationFrame to separate file

* Remove unneeded eslint disable

* Remove unneeded
---
 test/playwright/playwright-util.js | 3 ++-
 test/playwright/visual.spec.js     | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

(limited to 'test/playwright')

diff --git a/test/playwright/playwright-util.js b/test/playwright/playwright-util.js
index 425d6140..bf171251 100644
--- a/test/playwright/playwright-util.js
+++ b/test/playwright/playwright-util.js
@@ -23,7 +23,8 @@ const dirname = path.dirname(fileURLToPath(import.meta.url));
 export const root = path.join(dirname, '..', '..');
 
 export const test = base.extend({
-    context: async ({ }, use) => {
+    // eslint-disable-next-line no-empty-pattern
+    context: async ({}, use) => {
         const pathToExtension = path.join(root, 'ext');
         const context = await chromium.launchPersistentContext('', {
             // headless: false,
diff --git a/test/playwright/visual.spec.js b/test/playwright/visual.spec.js
index 3ecf4c6e..cc2a50d0 100644
--- a/test/playwright/visual.spec.js
+++ b/test/playwright/visual.spec.js
@@ -60,11 +60,11 @@ test('visual', async ({page, extensionId}) => {
 
         // Otherwise prepare for it to be attached
         let frame_attached;
-        if (popup_frame === undefined) {
+        if (typeof popup_frame === 'undefined') {
             frame_attached = page.waitForEvent('frameattached');
         }
         await page.mouse.move(box.x + offset.x, box.y + offset.y, {steps: 10}); // hover over the test
-        if (popup_frame === undefined) {
+        if (typeof popup_frame === 'undefined') {
             popup_frame = await frame_attached; // wait for popup to be attached
         }
         try {
-- 
cgit v1.2.3