From 01ff7436ee381c4414e95572cff08aac999b7721 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Mon, 23 Nov 2020 15:23:47 -0500 Subject: Popup setup refactoring (#1054) * Pass childrenSupported as a parameter to Frontend/Popup constructors * Remove setChildrenSupported * Use event listener instead of function override * Update options order * Expand options and use object for clarity * Fix childrenSupported not being fully propagated --- ext/mixed/js/display.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'ext/mixed/js') diff --git a/ext/mixed/js/display.js b/ext/mixed/js/display.js index 8b755b83..0bbdf730 100644 --- a/ext/mixed/js/display.js +++ b/ext/mixed/js/display.js @@ -1704,7 +1704,8 @@ class Display extends EventDispatcher { frameId, popupFactory, pageType: this._pageType, - allowRootFramePopupProxy: true + allowRootFramePopupProxy: true, + childrenSupported: this._childrenSupported }); const frontend = new Frontend(setupNestedPopupsOptions); -- cgit v1.2.3