From 900bceda47e4c736e70a66e66cfce719b4c6d203 Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Mon, 24 May 2021 18:53:42 -0400
Subject: Fix json schema array properties (#1709)

* Fix proxy array properties being handled incorrectly

* Add tests to check array properties
---
 ext/js/data/json-schema.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'ext/js')

diff --git a/ext/js/data/json-schema.js b/ext/js/data/json-schema.js
index a6306c3a..8fb920fc 100644
--- a/ext/js/data/json-schema.js
+++ b/ext/js/data/json-schema.js
@@ -852,11 +852,12 @@ class JsonSchemaProxyHandler {
 
         let propertySchema;
         if (Array.isArray(target)) {
-            property = this._getArrayIndex(property);
-            if (property === null) {
+            const index = this._getArrayIndex(property);
+            if (index === null) {
                 // Note: this does not currently wrap mutating functions like push, pop, shift, unshift, splice
                 return target[property];
             }
+            property = index;
             propertySchema = this._schema.getArrayItemSchema(property);
         } else {
             propertySchema = this._schema.getObjectPropertySchema(property);
-- 
cgit v1.2.3