From 2aea9291d66fd619c484abc2ab04b4350807f308 Mon Sep 17 00:00:00 2001
From: Jake <148171160+jbukl@users.noreply.github.com>
Date: Sat, 13 Jan 2024 00:17:08 -0500
Subject: Fix dictionary move to index (#514)

* Fix dictionary move to index

* Use number isnan
---
 ext/js/pages/settings/dictionary-controller.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'ext/js/pages/settings')

diff --git a/ext/js/pages/settings/dictionary-controller.js b/ext/js/pages/settings/dictionary-controller.js
index 0132fe9e..81b781da 100644
--- a/ext/js/pages/settings/dictionary-controller.js
+++ b/ext/js/pages/settings/dictionary-controller.js
@@ -716,9 +716,9 @@ export class DictionaryController {
     /** */
     _onDictionaryMoveButtonClick() {
         const modal = /** @type {import('./modal.js').Modal} */ (this._modalController.getModal('dictionary-move-location'));
-        const {index} = modal.node.dataset;
-        if (typeof index !== 'number') { return; }
+        const index = modal.node.dataset.index ?? '';
         const indexNumber = Number.parseInt(index, 10);
+        if (Number.isNaN(indexNumber)) { return; }
 
         /** @type {HTMLInputElement} */
         const targetStringInput = querySelectorNotNull(document, '#dictionary-move-location');
-- 
cgit v1.2.3