From e47a0f488f3d9bbcb76ebcf4f5afe203c1ee06c0 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Tue, 27 Feb 2024 07:23:42 -0500 Subject: Object utilities (#729) * Create utilities * Rename old isObject * Use new isObject * Remove old function * Add additional function * Simplify for now * Rename function for clarity * Rename function * Expand type * Update eslint --- ext/js/pages/settings/settings-controller.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'ext/js/pages/settings/settings-controller.js') diff --git a/ext/js/pages/settings/settings-controller.js b/ext/js/pages/settings/settings-controller.js index a9f3a026..ee44f875 100644 --- a/ext/js/pages/settings/settings-controller.js +++ b/ext/js/pages/settings/settings-controller.js @@ -18,7 +18,8 @@ import {EventDispatcher} from '../../core/event-dispatcher.js'; import {EventListenerCollection} from '../../core/event-listener-collection.js'; -import {generateId, isObject} from '../../core/utilities.js'; +import {isObjectNotArray} from '../../core/object-utilities.js'; +import {generateId} from '../../core/utilities.js'; import {OptionsUtil} from '../../data/options-util.js'; import {getAllPermissions} from '../../data/permissions-util.js'; import {HtmlTemplateCollection} from '../../dom/html-template-collection.js'; @@ -353,6 +354,6 @@ export class SettingsController extends EventDispatcher { * @returns {boolean} */ _canObservePermissionsChanges() { - return isObject(chrome.permissions) && isObject(chrome.permissions.onAdded) && isObject(chrome.permissions.onRemoved); + return isObjectNotArray(chrome.permissions) && isObjectNotArray(chrome.permissions.onAdded) && isObjectNotArray(chrome.permissions.onRemoved); } } -- cgit v1.2.3