From b0f6c41f5dc7f498f2948f846dd273bcb1bc1f0b Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Mon, 27 Sep 2021 19:07:28 -0400 Subject: Search query offset value (#1968) * Add type property to TextSource* classes * Use type property rather than instanceof * Expose a sentence offset value * Use offset added to URL * Improve fallback sentence for Anki note context --- ext/js/language/text-scanner.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'ext/js/language') diff --git a/ext/js/language/text-scanner.js b/ext/js/language/text-scanner.js index c7cedd7e..5d37c84b 100644 --- a/ext/js/language/text-scanner.js +++ b/ext/js/language/text-scanner.js @@ -17,7 +17,6 @@ /* global * DocumentUtil - * TextSourceElement */ class TextScanner extends EventDispatcher { @@ -345,7 +344,7 @@ class TextScanner extends EventDispatcher { if (result !== null) { ({dictionaryEntries, sentence, type} = result); valid = true; - } else if (textSource instanceof TextSourceElement && await this._hasJapanese(textSource.fullContent)) { + } else if (textSource !== null && textSource.type === 'element' && await this._hasJapanese(textSource.fullContent)) { dictionaryEntries = []; sentence = {sentence: '', offset: 0}; type = 'terms'; -- cgit v1.2.3