From 1e254fd1d4423b984e176547ef36a14383bbd7f5 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Thu, 28 Dec 2023 22:17:38 -0500 Subject: Event dispatcher refactor (#463) * Refactor EventDispatcher template type * Update core types * Update log * Update clipboard monitor * Update application events * Update popup events * Update text scanner * Update cross frame API * Update display events * Type updates * Update display history * Update query parser * Update search persistent state controller * Update panel element * Update popup menu * Update audio system * Update hotkey handler * Update settings controller * Update audio controller * Update types * Update types * Update types * Add event handler types * Update type * Fix issues * Remove error suppression * Fix typo --- ext/js/input/hotkey-handler.js | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) (limited to 'ext/js/input') diff --git a/ext/js/input/hotkey-handler.js b/ext/js/input/hotkey-handler.js index da763662..48c2de57 100644 --- a/ext/js/input/hotkey-handler.js +++ b/ext/js/input/hotkey-handler.js @@ -22,7 +22,7 @@ import {yomitan} from '../yomitan.js'; /** * Class which handles hotkey events and actions. - * @augments EventDispatcher + * @augments EventDispatcher */ export class HotkeyHandler extends EventDispatcher { /** @@ -120,25 +120,21 @@ export class HotkeyHandler extends EventDispatcher { } /** - * Adds a single event listener to a specific event. - * @template [TEventDetails=unknown] - * @param {import('hotkey-handler').EventType} eventName The string representing the event's name. - * @param {(details: TEventDetails) => void} callback The event listener callback to add. - * @returns {void} + * @template {import('core').EventNames} TName + * @param {TName} eventName + * @param {(details: import('core').EventArgument) => void} callback */ on(eventName, callback) { - const result = super.on(eventName, callback); + super.on(eventName, callback); this._updateHasEventListeners(); this._updateEventHandlers(); - return result; } /** - * Removes a single event listener from a specific event. - * @template [TEventDetails=unknown] - * @param {import('hotkey-handler').EventType} eventName The string representing the event's name. - * @param {(details: TEventDetails) => void} callback The event listener callback to add. - * @returns {boolean} `true` if the callback was removed, `false` otherwise. + * @template {import('core').EventNames} TName + * @param {TName} eventName + * @param {(details: import('core').EventArgument) => void} callback + * @returns {boolean} */ off(eventName, callback) { const result = super.off(eventName, callback); -- cgit v1.2.3