From b590a147015df21eec02054eb542ff23f2a4c0ef Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Mon, 2 Aug 2021 19:25:10 -0400 Subject: Improve audio auto play cancellation (#1873) * Cancel automatic audio playback when hiding the popup * Don't play audio if the popup is hidden --- ext/js/display/display.js | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) (limited to 'ext/js/display/display.js') diff --git a/ext/js/display/display.js b/ext/js/display/display.js index 9f1de06e..a9581def 100644 --- a/ext/js/display/display.js +++ b/ext/js/display/display.js @@ -111,6 +111,7 @@ class Display extends EventDispatcher { this._optionToggleHotkeyHandler = new OptionToggleHotkeyHandler(this); this._elementOverflowController = new ElementOverflowController(); this._displayAnki = new DisplayAnki(this, japaneseUtil); + this._popupVisible = false; this._hotkeyHandler.registerActions([ ['close', () => { this._onHotkeyClose(); }], @@ -132,7 +133,8 @@ class Display extends EventDispatcher { ['clearAutoPlayTimer', {async: false, handler: this._onMessageClearAutoPlayTimer.bind(this)}], ['setCustomCss', {async: false, handler: this._onMessageSetCustomCss.bind(this)}], ['setContentScale', {async: false, handler: this._onMessageSetContentScale.bind(this)}], - ['configure', {async: true, handler: this._onMessageConfigure.bind(this)}] + ['configure', {async: true, handler: this._onMessageConfigure.bind(this)}], + ['visibilityChanged', {async: false, handler: this._onMessageVisibilityChanged.bind(this)}] ]); this.registerWindowMessageHandlers([ ['extensionUnloaded', {async: false, handler: this._onMessageExtensionUnloaded.bind(this)}] @@ -208,6 +210,10 @@ class Display extends EventDispatcher { return this._fullQuery; } + get popupVisible() { + return this._popupVisible; + } + async prepare() { // State setup const {documentElement} = document; @@ -520,6 +526,14 @@ class Display extends EventDispatcher { await this.setOptionsContext(optionsContext); } + _onMessageVisibilityChanged({value}) { + this._popupVisible = value; + if (!value) { + this._displayAudio.clearAutoPlayTimer(); + this._displayAudio.stopAudio(); + } + } + _onMessageExtensionUnloaded() { if (yomichan.isExtensionUnloaded) { return; } yomichan.triggerExtensionUnloaded(); -- cgit v1.2.3