From ba3f7b3e96df7f034b56132d8c2c90289e16c288 Mon Sep 17 00:00:00 2001 From: soriac Date: Fri, 30 Apr 2021 18:57:53 -0300 Subject: Show any custom tags on words that have anki cards created (#1628) * Proof-of-concept for showing card tags (#1626) * Resolved most PR comments: - Added a snackbar notification when clicking tag button - Replaced magnifying glass icon with new tag icon - Button now contains a span w/icon, to use text color - Removed unnecessary attributes from button - Backend now returns full noteInfos object - Frontend now handles filtering tags * Add options to show/hide tag button & filter tags * Do not show tags button if, after filtering, we have zero tags. * Change tags option to enums, optimize tags intersection check & fix code style. * Update options-util.js to include new tag options. * Fix wording on new tag setting. * Add CSS to remove hidden buttons from the display layout. * getAnkiNoteInfo extra parameter for additional info. * Add new tag option to tests. * Remove unnecessary changes related to anki tags option. * Code style fixes. --- ext/js/data/options-util.js | 3 +++ 1 file changed, 3 insertions(+) (limited to 'ext/js/data') diff --git a/ext/js/data/options-util.js b/ext/js/data/options-util.js index 42f9a38f..cb7946f7 100644 --- a/ext/js/data/options-util.js +++ b/ext/js/data/options-util.js @@ -792,6 +792,7 @@ class OptionsUtil { // Version 11 changes: // Changed dictionaries to an array. // Changed audio.customSourceUrl's {expression} marker to {term}. + // Added anki.displayTags. const customSourceUrlPattern = /\{expression\}/g; for (const profile of options.profiles) { const dictionariesNew = []; @@ -805,6 +806,8 @@ class OptionsUtil { customSourceUrl = customSourceUrl.replace(customSourceUrlPattern, '{term}'); } profile.options.audio.customSourceUrl = customSourceUrl; + + profile.options.anki.displayTags = 'never'; } return options; } -- cgit v1.2.3