From 6bda81b4220cf6057f24e5b08aa9a62e4e535bc2 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Wed, 24 Feb 2021 22:23:40 -0500 Subject: Improve note addability (#1440) * Add valid field * Add isNoteDataValid function * Update _areDefinitionsAddableForcedValue to return proper valid values * Refactor isAnkiConnected check * Force canAdd to false if not valid --- ext/js/background/backend.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'ext/js/background') diff --git a/ext/js/background/backend.js b/ext/js/background/backend.js index 323219a4..f04006bc 100644 --- a/ext/js/background/backend.js +++ b/ext/js/background/backend.js @@ -17,6 +17,7 @@ /* global * AnkiConnect + * AnkiUtil * AudioDownloader * ClipboardMonitor * ClipboardReader @@ -456,10 +457,12 @@ class Backend { for (let i = 0; i < notes.length; ++i) { const note = notes[i]; - const canAdd = canAddArray[i]; - const info = {canAdd, noteIds: null}; + let canAdd = canAddArray[i]; + const valid = AnkiUtil.isNoteDataValid(note); + if (!valid) { canAdd = false; } + const info = {canAdd, valid, noteIds: null}; results.push(info); - if (!canAdd) { + if (!canAdd && valid) { cannotAdd.push({note, info}); } } -- cgit v1.2.3