From 6bf7b0055765c4f2011c9614753d6714dc09be65 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Wed, 14 Feb 2024 22:26:29 -0500 Subject: Eslint rule updates (#673) * Install unicorn * Add rules * Fix issues * Install sonarjs * Set up rules * Fix issues * Install eslint-plugin-import and fix import extensions * Simplify permitted error names --- ext/js/app/popup.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'ext/js/app/popup.js') diff --git a/ext/js/app/popup.js b/ext/js/app/popup.js index 08ff0661..103a5468 100644 --- a/ext/js/app/popup.js +++ b/ext/js/app/popup.js @@ -68,7 +68,7 @@ export class Popup extends EventDispatcher { /** @type {?import('settings').OptionsContext} */ this._optionsContext = null; /** @type {number} */ - this._contentScale = 1.0; + this._contentScale = 1; /** @type {string} */ this._targetOrigin = chrome.runtime.getURL('/').replace(/\/$/, ''); @@ -777,7 +777,7 @@ export class Popup extends EventDispatcher { _getPosition(sourceRects, writingMode, viewport) { sourceRects = this._convertSourceRectsCoordinateSpace(sourceRects); const contentScale = this._contentScale; - const scaleRatio = this._frameSizeContentScale === null ? 1.0 : contentScale / this._frameSizeContentScale; + const scaleRatio = this._frameSizeContentScale === null ? 1 : contentScale / this._frameSizeContentScale; this._frameSizeContentScale = contentScale; const frameRect = this._frame.getBoundingClientRect(); const frameWidth = Math.max(frameRect.width * scaleRatio, this._initialWidth * contentScale); @@ -1133,6 +1133,8 @@ class PopupError extends ExtensionError { */ constructor(message, source) { super(message); + /** @type {string} */ + this.name = 'PopupError'; /** @type {Popup} */ this._source = source; } -- cgit v1.2.3