From 75d30594511a6593044565829ad55369fecaf4cd Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Sun, 25 Sep 2022 09:37:33 -0400 Subject: TextSource* API updates (#2236) * Move TextSourceRange static functions to DocumentUtil getWritingMode is also simplified * Update Google Docs range to be empty to match other range sources * Rename imposterContainer to imposterElement * Add static creation functions * Add static creation function * Remove unused collapse function * Don't select imposter elements * Refactor setEndOffset * Adjust argument order for setEndOffset * Update TextSourceRange constructor * Remove unused isConnected * Cache rects * Fix test * Remove unused getRect * Revert "Fix test" * Remove cachedRect * Use the source element rect to handle scroll differences * Writing mode update * Remove _cachedRects update This shouldn't be necessary as the imposter is usually detached almost immediately after scanning, giving no time for the window to be resized or scrolled. --- ext/js/accessibility/google-docs-util.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'ext/js/accessibility') diff --git a/ext/js/accessibility/google-docs-util.js b/ext/js/accessibility/google-docs-util.js index e50ba652..12f2db24 100644 --- a/ext/js/accessibility/google-docs-util.js +++ b/ext/js/accessibility/google-docs-util.js @@ -87,7 +87,7 @@ class GoogleDocsUtil { const range = this._getRangeWithPoint(content, x, y, normalizeCssZoom); this._setImportantStyle(textStyle, 'pointer-events', 'none'); this._setImportantStyle(textStyle, 'opacity', '0'); - return new TextSourceRange(range, '', svgText, element); + return TextSourceRange.createFromImposter(range, svgText, element); } static _getRangeWithPoint(textNode, x, y, normalizeCssZoom) { @@ -110,7 +110,7 @@ class GoogleDocsUtil { } } range.setStart(textNode, start); - range.setEnd(textNode, end); + range.setEnd(textNode, start); return range; } -- cgit v1.2.3