From 1593a445f829f1494b0648156a03da6deb4d46d3 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Thu, 26 Nov 2020 22:53:58 -0500 Subject: Fix kanji note creation (#1069) * Fix kanji note creation * Move try/catch for consistency * Move audio normalization --- ext/bg/js/backend.js | 179 ++++++++++++++++++++++++++++----------------------- 1 file changed, 99 insertions(+), 80 deletions(-) (limited to 'ext/bg') diff --git a/ext/bg/js/backend.js b/ext/bg/js/backend.js index 65df0d49..f017d9e1 100644 --- a/ext/bg/js/backend.js +++ b/ext/bg/js/backend.js @@ -454,16 +454,15 @@ class Backend { return results; } - async _onApiInjectAnkiNoteMedia({expression, reading, timestamp, audioDetails, screenshotDetails, clipboardDetails}, sender) { + async _onApiInjectAnkiNoteMedia({timestamp, definitionDetails, audioDetails, screenshotDetails, clipboardDetails}, sender) { if (isObject(screenshotDetails)) { const {id: tabId, windowId} = (sender && sender.tab ? sender.tab : {}); screenshotDetails = Object.assign({}, screenshotDetails, {tabId, windowId}); } return await this._injectAnkNoteMedia( this._anki, - expression, - reading, timestamp, + definitionDetails, audioDetails, screenshotDetails, clipboardDetails @@ -1519,111 +1518,131 @@ class Backend { return await this._audioDownloader.downloadAudio(sources, expression, reading, details); } - async _injectAnkNoteMedia(ankiConnect, expression, reading, timestamp, audioDetails, screenshotDetails, clipboardDetails) { - const screenshotFileName = ( - screenshotDetails !== null ? - await this._injectAnkNoteScreenshot(ankiConnect, expression, reading, timestamp, screenshotDetails) : - null - ); - const clipboardImageFileName = ( - clipboardDetails !== null && clipboardDetails.image ? - await this._injectAnkNoteClipboardImage(ankiConnect, expression, reading, timestamp) : - null - ); + async _injectAnkNoteMedia(ankiConnect, timestamp, definitionDetails, audioDetails, screenshotDetails, clipboardDetails) { + let screenshotFileName = null; + let clipboardImageFileName = null; let clipboardText = null; + let audioFileName = null; + try { - if (clipboardDetails !== null && clipboardDetails.text) { - clipboardText = await this._clipboardReader.getText(); + if (screenshotDetails !== null) { + screenshotFileName = await this._injectAnkNoteScreenshot(ankiConnect, timestamp, definitionDetails, screenshotDetails); } } catch (e) { // NOP } - const audioFileName = ( - audioDetails !== null ? - await this._injectAnkNoteAudio(ankiConnect, expression, reading, timestamp, audioDetails) : - null - ); - return {screenshotFileName, clipboardImageFileName, clipboardText, audioFileName}; - } - async _injectAnkNoteAudio(ankiConnect, expression, reading, timestamp, details) { try { - if (!reading && !expression) { - throw new Error('Invalid reading and expression'); + if (clipboardDetails !== null && clipboardDetails.image) { + clipboardImageFileName = await this._injectAnkNoteClipboardImage(ankiConnect, timestamp, definitionDetails); } + } catch (e) { + // NOP + } - let fileName = 'yomichan'; - if (reading) { fileName += `_${reading}`; } - if (expression) { fileName += `_${expression}`; } - fileName += '.mp3'; - fileName = fileName.replace(/\]/g, ''); - fileName = this._replaceInvalidFileNameCharacters(fileName); - - const {sources, customSourceUrl} = details; - const data = await this._downloadDefinitionAudio( - sources, - expression, - reading, - { - textToSpeechVoice: null, - customSourceUrl, - binary: true, - disableCache: true - } - ); - - await ankiConnect.storeMediaFile(fileName, data); + try { + if (clipboardDetails !== null && clipboardDetails.text) { + clipboardText = await this._clipboardReader.getText(); + } + } catch (e) { + // NOP + } - return fileName; + try { + if (audioDetails !== null) { + audioFileName = await this._injectAnkNoteAudio(ankiConnect, timestamp, definitionDetails, audioDetails); + } } catch (e) { - return null; + // NOP } + + return {screenshotFileName, clipboardImageFileName, clipboardText, audioFileName}; } - async _injectAnkNoteScreenshot(ankiConnect, expression, reading, timestamp, details) { - try { - const now = new Date(timestamp); + async _injectAnkNoteAudio(ankiConnect, timestamp, definitionDetails, details) { + const {type, expression, reading} = definitionDetails; + if (type === 'kanji') { + throw new Error('Cannot inject audio for kanji'); + } + if (!reading && !expression) { + throw new Error('Invalid reading and expression'); + } + + const {sources, customSourceUrl} = details; + const data = await this._downloadDefinitionAudio( + sources, + expression, + reading, + { + textToSpeechVoice: null, + customSourceUrl, + binary: true, + disableCache: true + } + ); - const {windowId, tabId, ownerFrameId, format, quality} = details; - const dataUrl = await this._getScreenshot(windowId, tabId, ownerFrameId, format, quality); + let fileName = this._generateAnkiNoteMediaFileName('yomichan_audio', '.mp3', timestamp, definitionDetails); + fileName = fileName.replace(/\]/g, ''); + await ankiConnect.storeMediaFile(fileName, data); - const {mediaType, data} = this._getDataUrlInfo(dataUrl); - const extension = this._mediaUtility.getFileExtensionFromImageMediaType(mediaType); - if (extension === null) { throw new Error('Unknown image media type'); } + return fileName; + } - let fileName = `yomichan_browser_screenshot_${reading}_${this._ankNoteDateToString(now)}.${extension}`; - fileName = this._replaceInvalidFileNameCharacters(fileName); + async _injectAnkNoteScreenshot(ankiConnect, timestamp, definitionDetails, details) { + const {windowId, tabId, ownerFrameId, format, quality} = details; + const dataUrl = await this._getScreenshot(windowId, tabId, ownerFrameId, format, quality); - await ankiConnect.storeMediaFile(fileName, data); + const {mediaType, data} = this._getDataUrlInfo(dataUrl); + const extension = this._mediaUtility.getFileExtensionFromImageMediaType(mediaType); + if (extension === null) { throw new Error('Unknown image media type'); } - return fileName; - } catch (e) { - return null; - } + const fileName = this._generateAnkiNoteMediaFileName('yomichan_browser_screenshot', extension, timestamp, definitionDetails); + await ankiConnect.storeMediaFile(fileName, data); + + return fileName; } - async _injectAnkNoteClipboardImage(ankiConnect, expression, reading, timestamp) { - try { - const now = new Date(timestamp); + async _injectAnkNoteClipboardImage(ankiConnect, timestamp, definitionDetails) { + const dataUrl = await this._clipboardReader.getImage(); + if (dataUrl === null) { + throw new Error('No clipboard image'); + } - const dataUrl = await this._clipboardReader.getImage(); - if (dataUrl === null) { - throw new Error('No clipboard image'); - } + const {mediaType, data} = this._getDataUrlInfo(dataUrl); + const extension = this._mediaUtility.getFileExtensionFromImageMediaType(mediaType); + if (extension === null) { throw new Error('Unknown image media type'); } - const {mediaType, data} = this._getDataUrlInfo(dataUrl); - const extension = this._mediaUtility.getFileExtensionFromImageMediaType(mediaType); - if (extension === null) { throw new Error('Unknown image media type'); } + const fileName = this._generateAnkiNoteMediaFileName('yomichan_clipboard_image', extension, timestamp, definitionDetails); + await ankiConnect.storeMediaFile(fileName, data); - let fileName = `yomichan_clipboard_image_${reading}_${this._ankNoteDateToString(now)}.${extension}`; - fileName = this._replaceInvalidFileNameCharacters(fileName); + return fileName; + } - await ankiConnect.storeMediaFile(fileName, data); + _generateAnkiNoteMediaFileName(prefix, extension, timestamp, definitionDetails) { + let fileName = prefix; - return fileName; - } catch (e) { - return null; + switch (definitionDetails.type) { + case 'kanji': + { + const {character} = definitionDetails; + if (character) { fileName += `_${character}`; } + } + break; + default: + { + const {reading, expression} = definitionDetails; + if (reading) { fileName += `_${reading}`; } + if (expression) { fileName += `_${expression}`; } + } + break; } + + fileName += `_${this._ankNoteDateToString(new Date(timestamp))}`; + fileName += extension; + + fileName = this._replaceInvalidFileNameCharacters(fileName); + + return fileName; } _replaceInvalidFileNameCharacters(fileName) { -- cgit v1.2.3