From cab39e89c93a9b1826dce5d6555c213fa722c82e Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Sat, 7 Sep 2019 20:04:43 -0400
Subject: Create section for Popup Content Scanning Options

---
 ext/bg/settings.html | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

(limited to 'ext/bg/settings.html')

diff --git a/ext/bg/settings.html b/ext/bg/settings.html
index ddda8303..8c368474 100644
--- a/ext/bg/settings.html
+++ b/ext/bg/settings.html
@@ -221,14 +221,6 @@
                     <label><input type="checkbox" id="auto-hide-results"> Automatically hide results</label>
                 </div>
 
-                <div class="checkbox options-advanced">
-                    <label><input type="checkbox" id="enable-scanning-of-popup-expressions"> Enable scanning of popup expressions</label>
-                </div>
-
-                <div class="checkbox">
-                    <label><input type="checkbox" id="enable-scanning-on-search-page"> Enable scanning on search page</label>
-                </div>
-
                 <div class="checkbox options-advanced">
                     <label><input type="checkbox" id="deep-dom-scan"> Deep DOM scan</label>
                 </div>
@@ -252,9 +244,26 @@
                         <option value="shift">Shift</option>
                     </select>
                 </div>
+            </div>
 
-                <div class="form-group options-advanced">
-                    <label for="popup-nesting-max-depth">Maximum nested popup depth</label>
+            <div id="popup-content-scanning">
+                <h3>Popup Content Scanning Options</h3>
+
+                <p class="help-block">
+                    Yomichan is able to create additional popups in order to scan the content of other popups.
+                    This feature can be enabled if the <strong>Maximum number of additional popups</strong> option is set to a value greater than 0.
+                </p>
+
+                <div class="checkbox">
+                    <label><input type="checkbox" id="enable-scanning-on-search-page"> Enable scanning on search page</label>
+                </div>
+
+                <div class="checkbox">
+                    <label><input type="checkbox" id="enable-scanning-of-popup-expressions"> Enable scanning of popup expressions</label>
+                </div>
+
+                <div class="form-group">
+                    <label for="popup-nesting-max-depth">Maximum number of additional popups</label>
                     <input type="number" min="0" id="popup-nesting-max-depth" class="form-control">
                 </div>
             </div>
-- 
cgit v1.2.3


From 71b700cd22f5a57a07cd2f9a6afa823793f5f95e Mon Sep 17 00:00:00 2001
From: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Date: Tue, 10 Sep 2019 20:49:17 -0400
Subject: Add checkbox for options.general.enable

---
 ext/bg/js/settings.js | 2 ++
 ext/bg/settings.html  | 4 ++++
 2 files changed, 6 insertions(+)

(limited to 'ext/bg/settings.html')

diff --git a/ext/bg/js/settings.js b/ext/bg/js/settings.js
index 06dba538..f2f08b6e 100644
--- a/ext/bg/js/settings.js
+++ b/ext/bg/js/settings.js
@@ -23,6 +23,7 @@ function getOptionsContext() {
 }
 
 async function formRead(options) {
+    options.general.enable = $('#enable').prop('checked');
     options.general.showGuide = $('#show-usage-guide').prop('checked');
     options.general.compactTags = $('#compact-tags').prop('checked');
     options.general.compactGlossaries = $('#compact-glossaries').prop('checked');
@@ -87,6 +88,7 @@ async function formRead(options) {
 }
 
 async function formWrite(options) {
+    $('#enable').prop('checked', options.general.enable);
     $('#show-usage-guide').prop('checked', options.general.showGuide);
     $('#compact-tags').prop('checked', options.general.compactTags);
     $('#compact-glossaries').prop('checked', options.general.compactGlossaries);
diff --git a/ext/bg/settings.html b/ext/bg/settings.html
index 8c368474..577e1a1f 100644
--- a/ext/bg/settings.html
+++ b/ext/bg/settings.html
@@ -70,6 +70,10 @@
             <div>
                 <h3>General Options</h3>
 
+                <div class="checkbox">
+                    <label><input type="checkbox" id="enable"> Enable content scanning</label>
+                </div>
+
                 <div class="checkbox">
                     <label><input type="checkbox" id="show-usage-guide"> Show usage guide on startup</label>
                 </div>
-- 
cgit v1.2.3