From 44638b7ceb8ec4e2a235ad4ffc9aa23ec66f21d2 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Tue, 29 Oct 2019 16:31:27 -0400 Subject: Simplify how option visibility is changed --- ext/bg/js/settings.js | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-) (limited to 'ext/bg/js') diff --git a/ext/bg/js/settings.js b/ext/bg/js/settings.js index 05a0604a..f2250911 100644 --- a/ext/bg/js/settings.js +++ b/ext/bg/js/settings.js @@ -171,36 +171,16 @@ function formSetupEventListeners() { } function formUpdateVisibility(options) { - const general = $('#anki-general'); - if (options.anki.enable) { - general.show(); - } else { - general.hide(); - } - - const advanced = $('.options-advanced'); - if (options.general.showAdvanced) { - advanced.show(); - } else { - advanced.hide(); - } + document.documentElement.dataset.optionsAnkiEnable = `${!!options.anki.enable}`; + document.documentElement.dataset.optionsGeneralDebugInfo = `${!!options.general.debugInfo}`; + document.documentElement.dataset.optionsGeneralShowAdvanced = `${!!options.general.showAdvanced}`; + document.documentElement.dataset.optionsGeneralResultOutputMode = `${options.general.resultOutputMode}`; - const mainGroup = $('#dict-main-group'); - if (options.general.resultOutputMode === 'merge') { - mainGroup.show(); - } else { - mainGroup.hide(); - } - - const debug = $('#debug'); if (options.general.debugInfo) { const temp = utilIsolate(options); temp.anki.fieldTemplates = '...'; const text = JSON.stringify(temp, null, 4); - debug.html(handlebarsEscape(text)); - debug.show(); - } else { - debug.hide(); + $('#debug').text(text); } } -- cgit v1.2.3