From 39b2456ce9048d1d2b8a4f5ac5eb39554085cff5 Mon Sep 17 00:00:00 2001 From: siikamiika Date: Mon, 19 Aug 2019 19:47:45 +0300 Subject: fix off by one error --- ext/fg/js/source.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/fg/js/source.js b/ext/fg/js/source.js index bbf00e30..a360b331 100644 --- a/ext/fg/js/source.js +++ b/ext/fg/js/source.js @@ -180,7 +180,7 @@ class TextSourceRange { let consumed = 0; let stripped = 0; while (state.remainder - consumed > 0) { - const currentChar = node.nodeValue[offset - consumed - stripped]; // negative indices are undefined in JS + const currentChar = node.nodeValue[offset - 1 - consumed - stripped]; // negative indices are undefined in JS if (!currentChar) { break; } else if (currentChar.match(IGNORE_TEXT_PATTERN)) { -- cgit v1.2.3 From b7e3ded74ec461ca630960ff2cb07d421a59587f Mon Sep 17 00:00:00 2001 From: Alex Yatskov Date: Mon, 19 Aug 2019 19:33:30 -0700 Subject: version bump --- ext/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/manifest.json b/ext/manifest.json index 794d3c63..04847772 100644 --- a/ext/manifest.json +++ b/ext/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "Yomichan", - "version": "1.7.2", + "version": "1.7.3", "description": "Japanese dictionary with Anki integration (testing)", "icons": {"16": "mixed/img/icon16.png", "48": "mixed/img/icon48.png", "128": "mixed/img/icon128.png"}, -- cgit v1.2.3 From 6c3671b3d98896ea710d70927024db4d2cbbad06 Mon Sep 17 00:00:00 2001 From: Alex Yatskov Date: Mon, 19 Aug 2019 19:40:33 -0700 Subject: version bump --- ext/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/manifest.json b/ext/manifest.json index 04847772..4184273d 100644 --- a/ext/manifest.json +++ b/ext/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "Yomichan", - "version": "1.7.3", + "version": "1.7.4", "description": "Japanese dictionary with Anki integration (testing)", "icons": {"16": "mixed/img/icon16.png", "48": "mixed/img/icon48.png", "128": "mixed/img/icon128.png"}, -- cgit v1.2.3