From 33ec369eff87ace3e8b49c6461fa1b9a5d2a1202 Mon Sep 17 00:00:00 2001 From: toasted-nutbread Date: Mon, 10 Dec 2018 17:09:06 -0500 Subject: Catch exceptions thrown by range.getClientRects() Firefox dev 65 was throwing an exception --- ext/fg/js/document.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/ext/fg/js/document.js b/ext/fg/js/document.js index 9366832e..73e89d99 100644 --- a/ext/fg/js/document.js +++ b/ext/fg/js/document.js @@ -92,7 +92,19 @@ function docRangeFromPoint(point) { if(imposter !== null) imposter.style.zIndex = -2147483646; - const rect = range.getClientRects()[0]; + let rects; + try { + rects = range.getClientRects(); + } + catch (e) { + return; + } + + if (rects.length === 0) { + return; + } + + const rect = rects[0]; if (point.y > rect.bottom + 2) { return; } -- cgit v1.2.3