diff options
Diffstat (limited to 'ext')
| -rw-r--r-- | ext/bg/data/dictionary-term-meta-bank-v3-schema.json | 26 | ||||
| -rw-r--r-- | ext/bg/js/backend.js | 169 | ||||
| -rw-r--r-- | ext/bg/js/database.js | 3 | ||||
| -rw-r--r-- | ext/bg/js/japanese.js | 24 | ||||
| -rw-r--r-- | ext/bg/js/mecab.js | 31 | ||||
| -rw-r--r-- | ext/bg/js/options.js | 23 | ||||
| -rw-r--r-- | ext/bg/js/search-frontend.js | 40 | ||||
| -rw-r--r-- | ext/bg/js/search-query-parser-generator.js | 14 | ||||
| -rw-r--r-- | ext/bg/js/search-query-parser.js | 31 | ||||
| -rw-r--r-- | ext/bg/js/settings/anki.js | 10 | ||||
| -rw-r--r-- | ext/bg/js/settings/dictionaries.js | 12 | ||||
| -rw-r--r-- | ext/bg/js/translator.js | 16 | ||||
| -rw-r--r-- | ext/bg/js/util.js | 42 | ||||
| -rw-r--r-- | ext/fg/js/frontend-initialize.js | 128 | ||||
| -rw-r--r-- | ext/fg/js/frontend.js | 25 | ||||
| -rw-r--r-- | ext/fg/js/popup-nested.js | 49 | ||||
| -rw-r--r-- | ext/fg/js/popup.js | 11 | ||||
| -rw-r--r-- | ext/manifest.json | 2 | ||||
| -rw-r--r-- | ext/mixed/js/api.js | 28 | ||||
| -rw-r--r-- | ext/mixed/js/core.js | 9 | ||||
| -rw-r--r-- | ext/mixed/js/text-scanner.js | 10 | 
21 files changed, 449 insertions, 254 deletions
| diff --git a/ext/bg/data/dictionary-term-meta-bank-v3-schema.json b/ext/bg/data/dictionary-term-meta-bank-v3-schema.json index 8475db81..ffffb546 100644 --- a/ext/bg/data/dictionary-term-meta-bank-v3-schema.json +++ b/ext/bg/data/dictionary-term-meta-bank-v3-schema.json @@ -26,8 +26,30 @@                      {},                      {"enum": ["freq"]},                      { -                        "type": ["string", "number"], -                        "description": "Frequency information for the term or expression." +                        "oneOf": [ +                            { +                                "type": ["string", "number"], +                                "description": "Frequency information for the term or expression." +                            }, +                            { +                                "type": ["object"], +                                "required": [ +                                    "reading", +                                    "frequency" +                                ], +                                "additionalProperties": false, +                                "properties": { +                                    "reading": { +                                        "type": "string", +                                        "description": "Reading for the term or expression." +                                    }, +                                    "frequency": { +                                        "type": ["string", "number"], +                                        "description": "Frequency information for the term or expression." +                                    } +                                } +                            } +                        ]                      }                  ]              }, diff --git a/ext/bg/js/backend.js b/ext/bg/js/backend.js index 1b922730..a1b788df 100644 --- a/ext/bg/js/backend.js +++ b/ext/bg/js/backend.js @@ -29,7 +29,6 @@   * Translator   * conditionsTestValue   * dictConfigured - * dictEnabledSet   * dictTermsSort   * handlebarsRenderDynamic   * jp @@ -85,7 +84,6 @@ class Backend {              ['kanjiFind', {handler: this._onApiKanjiFind.bind(this), async: true}],              ['termsFind', {handler: this._onApiTermsFind.bind(this), async: true}],              ['textParse', {handler: this._onApiTextParse.bind(this), async: true}], -            ['textParseMecab', {handler: this._onApiTextParseMecab.bind(this), async: true}],              ['definitionAdd', {handler: this._onApiDefinitionAdd.bind(this), async: true}],              ['definitionsAddable', {handler: this._onApiDefinitionsAddable.bind(this), async: true}],              ['noteView', {handler: this._onApiNoteView.bind(this), async: true}], @@ -102,7 +100,13 @@ class Backend {              ['getQueryParserTemplatesHtml', {handler: this._onApiGetQueryParserTemplatesHtml.bind(this), async: true}],              ['getZoom', {handler: this._onApiGetZoom.bind(this), async: true}],              ['getMessageToken', {handler: this._onApiGetMessageToken.bind(this), async: false}], -            ['getDefaultAnkiFieldTemplates', {handler: this._onApiGetDefaultAnkiFieldTemplates.bind(this), async: false}] +            ['getDefaultAnkiFieldTemplates', {handler: this._onApiGetDefaultAnkiFieldTemplates.bind(this), async: false}], +            ['getAnkiDeckNames', {handler: this._onApiGetAnkiDeckNames.bind(this), async: true}], +            ['getAnkiModelNames', {handler: this._onApiGetAnkiModelNames.bind(this), async: true}], +            ['getAnkiModelFieldNames', {handler: this._onApiGetAnkiModelFieldNames.bind(this), async: true}], +            ['getDictionaryInfo', {handler: this._onApiGetDictionaryInfo.bind(this), async: true}], +            ['getDictionaryCounts', {handler: this._onApiGetDictionaryCounts.bind(this), async: true}], +            ['purgeDatabase', {handler: this._onApiPurgeDatabase.bind(this), async: true}]          ]);          this._commandHandlers = new Map([ @@ -316,6 +320,60 @@ class Backend {          return await this.dictionaryImporter.import(this.database, archiveSource, onProgress, details);      } +    async _textParseScanning(text, options) { +        const results = []; +        while (text.length > 0) { +            const term = []; +            const [definitions, sourceLength] = await this.translator.findTerms( +                'simple', +                text.substring(0, options.scanning.length), +                {}, +                options +            ); +            if (definitions.length > 0 && sourceLength > 0) { +                dictTermsSort(definitions); +                const {expression, reading} = definitions[0]; +                const source = text.substring(0, sourceLength); +                for (const {text: text2, furigana} of jp.distributeFuriganaInflected(expression, reading, source)) { +                    const reading2 = jp.convertReading(text2, furigana, options.parsing.readingMode); +                    term.push({text: text2, reading: reading2}); +                } +                text = text.substring(source.length); +            } else { +                const reading = jp.convertReading(text[0], '', options.parsing.readingMode); +                term.push({text: text[0], reading}); +                text = text.substring(1); +            } +            results.push(term); +        } +        return results; +    } + +    async _textParseMecab(text, options) { +        const results = []; +        const rawResults = await this.mecab.parseText(text); +        for (const [mecabName, parsedLines] of Object.entries(rawResults)) { +            const result = []; +            for (const parsedLine of parsedLines) { +                for (const {expression, reading, source} of parsedLine) { +                    const term = []; +                    for (const {text: text2, furigana} of jp.distributeFuriganaInflected( +                        expression.length > 0 ? expression : source, +                        jp.convertKatakanaToHiragana(reading), +                        source +                    )) { +                        const reading2 = jp.convertReading(text2, furigana, options.parsing.readingMode); +                        term.push({text: text2, reading: reading2}); +                    } +                    result.push(term); +                } +                result.push([{text: '\n', reading: ''}]); +            } +            results.push([mecabName, result]); +        } +        return results; +    } +      // Message handlers      _onApiYomichanCoreReady(_params, sender) { @@ -407,61 +465,27 @@ class Backend {      async _onApiTextParse({text, optionsContext}) {          const options = this.getOptions(optionsContext);          const results = []; -        while (text.length > 0) { -            const term = []; -            const [definitions, sourceLength] = await this.translator.findTerms( -                'simple', -                text.substring(0, options.scanning.length), -                {}, -                options -            ); -            if (definitions.length > 0) { -                dictTermsSort(definitions); -                const {expression, reading} = definitions[0]; -                const source = text.substring(0, sourceLength); -                for (const {text: text2, furigana} of jp.distributeFuriganaInflected(expression, reading, source)) { -                    const reading2 = jp.convertReading(text2, furigana, options.parsing.readingMode); -                    term.push({text: text2, reading: reading2}); -                } -                text = text.substring(source.length); -            } else { -                const reading = jp.convertReading(text[0], null, options.parsing.readingMode); -                term.push({text: text[0], reading}); -                text = text.substring(1); -            } -            results.push(term); + +        if (options.parsing.enableScanningParser) { +            results.push({ +                source: 'scanning-parser', +                id: 'scan', +                content: await this._textParseScanning(text, options) +            });          } -        return results; -    } -    async _onApiTextParseMecab({text, optionsContext}) { -        const options = this.getOptions(optionsContext); -        const results = []; -        const rawResults = await this.mecab.parseText(text); -        for (const [mecabName, parsedLines] of Object.entries(rawResults)) { -            const result = []; -            for (const parsedLine of parsedLines) { -                for (const {expression, reading, source} of parsedLine) { -                    const term = []; -                    if (expression !== null && reading !== null) { -                        for (const {text: text2, furigana} of jp.distributeFuriganaInflected( -                            expression, -                            jp.convertKatakanaToHiragana(reading), -                            source -                        )) { -                            const reading2 = jp.convertReading(text2, furigana, options.parsing.readingMode); -                            term.push({text: text2, reading: reading2}); -                        } -                    } else { -                        const reading2 = jp.convertReading(source, null, options.parsing.readingMode); -                        term.push({text: source, reading: reading2}); -                    } -                    result.push(term); -                } -                result.push([{text: '\n'}]); +        if (options.parsing.enableMecabParser) { +            const mecabResults = await this._textParseMecab(text, options); +            for (const [mecabDictName, mecabDictResults] of mecabResults) { +                results.push({ +                    source: 'mecab', +                    dictionary: mecabDictName, +                    id: `mecab-${mecabDictName}`, +                    content: mecabDictResults +                });              } -            results.push([mecabName, result]);          } +          return results;      } @@ -704,6 +728,36 @@ class Backend {          return this.defaultAnkiFieldTemplates;      } +    async _onApiGetAnkiDeckNames(params, sender) { +        this._validatePrivilegedMessageSender(sender); +        return await this.anki.getDeckNames(); +    } + +    async _onApiGetAnkiModelNames(params, sender) { +        this._validatePrivilegedMessageSender(sender); +        return await this.anki.getModelNames(); +    } + +    async _onApiGetAnkiModelFieldNames({modelName}, sender) { +        this._validatePrivilegedMessageSender(sender); +        return await this.anki.getModelFieldNames(modelName); +    } + +    async _onApiGetDictionaryInfo(params, sender) { +        this._validatePrivilegedMessageSender(sender); +        return await this.translator.database.getDictionaryInfo(); +    } + +    async _onApiGetDictionaryCounts({dictionaryNames, getTotal}, sender) { +        this._validatePrivilegedMessageSender(sender); +        return await this.translator.database.getDictionaryCounts(dictionaryNames, getTotal); +    } + +    async _onApiPurgeDatabase(params, sender) { +        this._validatePrivilegedMessageSender(sender); +        return await this.translator.purgeDatabase(); +    } +      // Command handlers      async _onCommandSearch(params) { @@ -800,6 +854,13 @@ class Backend {      // Utilities +    _validatePrivilegedMessageSender(sender) { +        const url = sender.url; +        if (!(typeof url === 'string' && yomichan.isExtensionUrl(url))) { +            throw new Error('Invalid message sender'); +        } +    } +      async _getAudioUri(definition, source, details) {          let optionsContext = (typeof details === 'object' && details !== null ? details.optionsContext : null);          if (!(typeof optionsContext === 'object' && optionsContext !== null)) { diff --git a/ext/bg/js/database.js b/ext/bg/js/database.js index ad4e3bad..260c815a 100644 --- a/ext/bg/js/database.js +++ b/ext/bg/js/database.js @@ -16,10 +16,7 @@   */  /* global - * JSZip - * JsonSchema   * dictFieldSplit - * requestJson   */  class Database { diff --git a/ext/bg/js/japanese.js b/ext/bg/js/japanese.js index 5fef27a7..ac81acb5 100644 --- a/ext/bg/js/japanese.js +++ b/ext/bg/js/japanese.js @@ -124,25 +124,25 @@          return wanakana.toRomaji(text);      } -    function convertReading(expressionFragment, readingFragment, readingMode) { +    function convertReading(expression, reading, readingMode) {          switch (readingMode) {              case 'hiragana': -                return convertKatakanaToHiragana(readingFragment || ''); +                return convertKatakanaToHiragana(reading);              case 'katakana': -                return convertHiraganaToKatakana(readingFragment || ''); +                return convertHiraganaToKatakana(reading);              case 'romaji': -                if (readingFragment) { -                    return convertToRomaji(readingFragment); +                if (reading) { +                    return convertToRomaji(reading);                  } else { -                    if (isStringEntirelyKana(expressionFragment)) { -                        return convertToRomaji(expressionFragment); +                    if (isStringEntirelyKana(expression)) { +                        return convertToRomaji(expression);                      }                  } -                return readingFragment; +                return reading;              case 'none': -                return null; +                return '';              default: -                return readingFragment; +                return reading;          }      } @@ -300,7 +300,7 @@                      const readingLeft = reading2.substring(group.text.length);                      const segs = segmentize(readingLeft, groups.splice(1));                      if (segs) { -                        return [{text: group.text}].concat(segs); +                        return [{text: group.text, furigana: ''}].concat(segs);                      }                  }              } else { @@ -368,7 +368,7 @@          }          if (stemLength !== source.length) { -            output.push({text: source.substring(stemLength)}); +            output.push({text: source.substring(stemLength), furigana: ''});          }          return output; diff --git a/ext/bg/js/mecab.js b/ext/bg/js/mecab.js index cd6e6c57..597dceae 100644 --- a/ext/bg/js/mecab.js +++ b/ext/bg/js/mecab.js @@ -40,7 +40,36 @@ class Mecab {      }      async parseText(text) { -        return await this.invoke('parse_text', {text}); +        const rawResults = await this.invoke('parse_text', {text}); +        // { +        //     'mecab-name': [ +        //         // line1 +        //         [ +        //             {str expression: 'expression', str reading: 'reading', str source: 'source'}, +        //             {str expression: 'expression2', str reading: 'reading2', str source: 'source2'} +        //         ], +        //         line2, +        //         ... +        //     ], +        //     'mecab-name2': [...] +        // } +        const results = {}; +        for (const [mecabName, parsedLines] of Object.entries(rawResults)) { +            const result = []; +            for (const parsedLine of parsedLines) { +                const line = []; +                for (const {expression, reading, source} of parsedLine) { +                    line.push({ +                        expression: expression || '', +                        reading: reading || '', +                        source: source || '' +                    }); +                } +                result.push(line); +            } +            results[mecabName] = result; +        } +        return results;      }      startListener() { diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js index f3e5f60d..da26b628 100644 --- a/ext/bg/js/options.js +++ b/ext/bg/js/options.js @@ -15,14 +15,23 @@   * along with this program.  If not, see <https://www.gnu.org/licenses/>.   */ -/* global - * utilStringHashCode - */ -  /*   * Generic options functions   */ +function optionsGetStringHashCode(string) { +    let hashCode = 0; + +    if (typeof string !== 'string') { return hashCode; } + +    for (let i = 0, charCode = string.charCodeAt(i); i < string.length; charCode = string.charCodeAt(++i)) { +        hashCode = ((hashCode << 5) - hashCode) + charCode; +        hashCode |= 0; +    } + +    return hashCode; +} +  function optionsGenericApplyUpdates(options, updates) {      const targetVersion = updates.length;      const currentVersion = options.version; @@ -63,12 +72,12 @@ const profileOptionsVersionUpdates = [          options.anki.fieldTemplates = null;      },      (options) => { -        if (utilStringHashCode(options.anki.fieldTemplates) === 1285806040) { +        if (optionsGetStringHashCode(options.anki.fieldTemplates) === 1285806040) {              options.anki.fieldTemplates = null;          }      },      (options) => { -        if (utilStringHashCode(options.anki.fieldTemplates) === -250091611) { +        if (optionsGetStringHashCode(options.anki.fieldTemplates) === -250091611) {              options.anki.fieldTemplates = null;          }      }, @@ -87,7 +96,7 @@ const profileOptionsVersionUpdates = [      (options) => {          // Version 12 changes:          //  The preferred default value of options.anki.fieldTemplates has been changed to null. -        if (utilStringHashCode(options.anki.fieldTemplates) === 1444379824) { +        if (optionsGetStringHashCode(options.anki.fieldTemplates) === 1444379824) {              options.anki.fieldTemplates = null;          }      }, diff --git a/ext/bg/js/search-frontend.js b/ext/bg/js/search-frontend.js index 9cc1436f..e534e771 100644 --- a/ext/bg/js/search-frontend.js +++ b/ext/bg/js/search-frontend.js @@ -19,18 +19,7 @@   * apiOptionsGet   */ -async function searchFrontendSetup() { -    await yomichan.prepare(); - -    const optionsContext = { -        depth: 0, -        url: window.location.href -    }; -    const options = await apiOptionsGet(optionsContext); -    if (!options.scanning.enableOnSearchPage) { return; } - -    window.frontendInitializationData = {depth: 1, proxy: false}; - +function injectSearchFrontend() {      const scriptSrcs = [          '/mixed/js/text-scanner.js',          '/fg/js/frontend-api-receiver.js', @@ -62,4 +51,29 @@ async function searchFrontendSetup() {      }  } -searchFrontendSetup(); +async function main() { +    await yomichan.prepare(); + +    let optionsApplied = false; + +    const applyOptions = async () => { +        const optionsContext = { +            depth: 0, +            url: window.location.href +        }; +        const options = await apiOptionsGet(optionsContext); +        if (!options.scanning.enableOnSearchPage || optionsApplied) { return; } +        optionsApplied = true; + +        window.frontendInitializationData = {depth: 1, proxy: false, isSearchPage: true}; +        injectSearchFrontend(); + +        yomichan.off('optionsUpdated', applyOptions); +    }; + +    yomichan.on('optionsUpdated', applyOptions); + +    await applyOptions(); +} + +main(); diff --git a/ext/bg/js/search-query-parser-generator.js b/ext/bg/js/search-query-parser-generator.js index 390841c1..9e7ff8aa 100644 --- a/ext/bg/js/search-query-parser-generator.js +++ b/ext/bg/js/search-query-parser-generator.js @@ -36,7 +36,7 @@ class QueryParserGenerator {              const termContainer = this._templateHandler.instantiate(preview ? 'term-preview' : 'term');              for (const segment of term) {                  if (!segment.text.trim()) { continue; } -                if (!segment.reading || !segment.reading.trim()) { +                if (!segment.reading.trim()) {                      termContainer.appendChild(this.createSegmentText(segment.text));                  } else {                      termContainer.appendChild(this.createSegment(segment)); @@ -71,7 +71,17 @@ class QueryParserGenerator {          for (const parseResult of parseResults) {              const optionContainer = this._templateHandler.instantiate('select-option');              optionContainer.value = parseResult.id; -            optionContainer.textContent = parseResult.name; +            switch (parseResult.source) { +                case 'scanning-parser': +                    optionContainer.textContent = 'Scanning parser'; +                    break; +                case 'mecab': +                    optionContainer.textContent = `MeCab: ${parseResult.dictionary}`; +                    break; +                default: +                    optionContainer.textContent = 'Unrecognized dictionary'; +                    break; +            }              optionContainer.defaultSelected = selectedParser === parseResult.id;              selectContainer.appendChild(optionContainer);          } diff --git a/ext/bg/js/search-query-parser.js b/ext/bg/js/search-query-parser.js index 01a0ace5..eb3b681c 100644 --- a/ext/bg/js/search-query-parser.js +++ b/ext/bg/js/search-query-parser.js @@ -21,13 +21,12 @@   * apiOptionsSet   * apiTermsFind   * apiTextParse - * apiTextParseMecab   * docSentenceExtract   */  class QueryParser extends TextScanner {      constructor({getOptionsContext, setContent, setSpinnerVisible}) { -        super(document.querySelector('#query-parser-content'), [], []); +        super(document.querySelector('#query-parser-content'), () => [], []);          this.getOptionsContext = getOptionsContext;          this.setContent = setContent; @@ -128,7 +127,7 @@ class QueryParser extends TextScanner {          this.setPreview(text); -        this.parseResults = await this.parseText(text); +        this.parseResults = await apiTextParse(text, this.getOptionsContext());          this.refreshSelectedParser();          this.renderParserSelect(); @@ -137,33 +136,11 @@ class QueryParser extends TextScanner {          this.setSpinnerVisible(false);      } -    async parseText(text) { -        const results = []; -        if (this.options.parsing.enableScanningParser) { -            results.push({ -                name: 'Scanning parser', -                id: 'scan', -                parsedText: await apiTextParse(text, this.getOptionsContext()) -            }); -        } -        if (this.options.parsing.enableMecabParser) { -            const mecabResults = await apiTextParseMecab(text, this.getOptionsContext()); -            for (const [mecabDictName, mecabDictResults] of mecabResults) { -                results.push({ -                    name: `MeCab: ${mecabDictName}`, -                    id: `mecab-${mecabDictName}`, -                    parsedText: mecabDictResults -                }); -            } -        } -        return results; -    } -      setPreview(text) {          const previewTerms = [];          for (let i = 0, ii = text.length; i < ii; i += 2) {              const tempText = text.substring(i, i + 2); -            previewTerms.push([{text: tempText}]); +            previewTerms.push([{text: tempText, reading: ''}]);          }          this.queryParser.textContent = '';          this.queryParser.appendChild(this.queryParserGenerator.createParseResult(previewTerms, true)); @@ -183,6 +160,6 @@ class QueryParser extends TextScanner {          const parseResult = this.getParseResult();          this.queryParser.textContent = '';          if (!parseResult) { return; } -        this.queryParser.appendChild(this.queryParserGenerator.createParseResult(parseResult.parsedText)); +        this.queryParser.appendChild(this.queryParserGenerator.createParseResult(parseResult.content));      }  } diff --git a/ext/bg/js/settings/anki.js b/ext/bg/js/settings/anki.js index b32a9517..ff1277ed 100644 --- a/ext/bg/js/settings/anki.js +++ b/ext/bg/js/settings/anki.js @@ -16,13 +16,13 @@   */  /* global + * apiGetAnkiDeckNames + * apiGetAnkiModelFieldNames + * apiGetAnkiModelNames   * getOptionsContext   * getOptionsMutable   * onFormOptionsChanged   * settingsSaveOptions - * utilAnkiGetDeckNames - * utilAnkiGetModelFieldNames - * utilAnkiGetModelNames   * utilBackgroundIsolate   */ @@ -107,7 +107,7 @@ async function _ankiDeckAndModelPopulate(options) {      const kanjiModel = {value: options.anki.kanji.model, selector: '#anki-kanji-model'};      try {          _ankiSpinnerShow(true); -        const [deckNames, modelNames] = await Promise.all([utilAnkiGetDeckNames(), utilAnkiGetModelNames()]); +        const [deckNames, modelNames] = await Promise.all([apiGetAnkiDeckNames(), apiGetAnkiModelNames()]);          deckNames.sort();          modelNames.sort();          termsDeck.values = deckNames; @@ -180,7 +180,7 @@ async function _onAnkiModelChanged(e) {      let fieldNames;      try {          const modelName = node.value; -        fieldNames = await utilAnkiGetModelFieldNames(modelName); +        fieldNames = await apiGetAnkiModelFieldNames(modelName);          _ankiSetError(null);      } catch (error) {          _ankiSetError(error); diff --git a/ext/bg/js/settings/dictionaries.js b/ext/bg/js/settings/dictionaries.js index 1a6d452b..7eed4273 100644 --- a/ext/bg/js/settings/dictionaries.js +++ b/ext/bg/js/settings/dictionaries.js @@ -17,8 +17,11 @@  /* global   * PageExitPrevention + * apiGetDictionaryCounts + * apiGetDictionaryInfo   * apiOptionsGet   * apiOptionsGetFull + * apiPurgeDatabase   * getOptionsContext   * getOptionsFullMutable   * getOptionsMutable @@ -27,10 +30,7 @@   * storageUpdateStats   * utilBackgroundIsolate   * utilDatabaseDeleteDictionary - * utilDatabaseGetDictionaryCounts - * utilDatabaseGetDictionaryInfo   * utilDatabaseImport - * utilDatabasePurge   */  let dictionaryUI = null; @@ -431,7 +431,7 @@ async function onDictionaryOptionsChanged() {  async function onDatabaseUpdated() {      try { -        const dictionaries = await utilDatabaseGetDictionaryInfo(); +        const dictionaries = await apiGetDictionaryInfo();          dictionaryUI.setDictionaries(dictionaries);          document.querySelector('#dict-warning').hidden = (dictionaries.length > 0); @@ -439,7 +439,7 @@ async function onDatabaseUpdated() {          updateMainDictionarySelectOptions(dictionaries);          await updateMainDictionarySelectValue(); -        const {counts, total} = await utilDatabaseGetDictionaryCounts(dictionaries.map((v) => v.title), true); +        const {counts, total} = await apiGetDictionaryCounts(dictionaries.map((v) => v.title), true);          dictionaryUI.setCounts(counts, total);      } catch (e) {          dictionaryErrorsShow([e]); @@ -618,7 +618,7 @@ async function onDictionaryPurge(e) {          dictionaryErrorsShow(null);          dictionarySpinnerShow(true); -        await utilDatabasePurge(); +        await apiPurgeDatabase();          for (const {options} of toIterable((await getOptionsFullMutable()).profiles)) {              options.dictionaries = utilBackgroundIsolate({});              options.general.mainDictionary = ''; diff --git a/ext/bg/js/translator.js b/ext/bg/js/translator.js index aaa1a0ec..8708e4d8 100644 --- a/ext/bg/js/translator.js +++ b/ext/bg/js/translator.js @@ -482,7 +482,9 @@ class Translator {              switch (mode) {                  case 'freq':                      for (const term of termsUnique[index]) { -                        term.frequencies.push({expression, frequency: data, dictionary}); +                        const frequencyData = this.getFrequencyData(expression, data, dictionary, term); +                        if (frequencyData === null) { continue; } +                        term.frequencies.push(frequencyData);                      }                      break;                  case 'pitch': @@ -575,6 +577,18 @@ class Translator {          return tagMetaList;      } +    getFrequencyData(expression, data, dictionary, term) { +        if (data !== null && typeof data === 'object') { +            const {frequency, reading} = data; + +            const termReading = term.reading || expression; +            if (reading !== termReading) { return null; } + +            return {expression, frequency, dictionary}; +        } +        return {expression, frequency: data, dictionary}; +    } +      async getPitchData(expression, data, dictionary, term) {          const reading = data.reading;          const termReading = term.reading || expression; diff --git a/ext/bg/js/util.js b/ext/bg/js/util.js index 69536f02..5edcc193 100644 --- a/ext/bg/js/util.js +++ b/ext/bg/js/util.js @@ -58,19 +58,6 @@ function utilBackgroundFunctionIsolate(func) {      return backgroundPage.utilFunctionIsolate(func);  } -function utilStringHashCode(string) { -    let hashCode = 0; - -    if (typeof string !== 'string') { return hashCode; } - -    for (let i = 0, charCode = string.charCodeAt(i); i < string.length; charCode = string.charCodeAt(++i)) { -        hashCode = ((hashCode << 5) - hashCode) + charCode; -        hashCode |= 0; -    } - -    return hashCode; -} -  function utilBackend() {      const backend = chrome.extension.getBackgroundPage().yomichanBackend;      if (!backend.isPrepared) { @@ -79,35 +66,6 @@ function utilBackend() {      return backend;  } -async function utilAnkiGetModelNames() { -    return utilIsolate(await utilBackend().anki.getModelNames()); -} - -async function utilAnkiGetDeckNames() { -    return utilIsolate(await utilBackend().anki.getDeckNames()); -} - -async function utilDatabaseGetDictionaryInfo() { -    return utilIsolate(await utilBackend().translator.database.getDictionaryInfo()); -} - -async function utilDatabaseGetDictionaryCounts(dictionaryNames, getTotal) { -    return utilIsolate(await utilBackend().translator.database.getDictionaryCounts( -        utilBackgroundIsolate(dictionaryNames), -        utilBackgroundIsolate(getTotal) -    )); -} - -async function utilAnkiGetModelFieldNames(modelName) { -    return utilIsolate(await utilBackend().anki.getModelFieldNames( -        utilBackgroundIsolate(modelName) -    )); -} - -async function utilDatabasePurge() { -    return utilIsolate(await utilBackend().translator.purgeDatabase()); -} -  async function utilDatabaseDeleteDictionary(dictionaryName, onProgress) {      return utilIsolate(await utilBackend().translator.database.deleteDictionary(          utilBackgroundIsolate(dictionaryName), diff --git a/ext/fg/js/frontend-initialize.js b/ext/fg/js/frontend-initialize.js index 5af7fdf0..2b942258 100644 --- a/ext/fg/js/frontend-initialize.js +++ b/ext/fg/js/frontend-initialize.js @@ -24,49 +24,101 @@   * apiOptionsGet   */ +async function createIframePopupProxy(url, frameOffsetForwarder) { +    const rootPopupInformationPromise = yomichan.getTemporaryListenerResult( +        chrome.runtime.onMessage, +        ({action, params}, {resolve}) => { +            if (action === 'rootPopupInformation') { +                resolve(params); +            } +        } +    ); +    apiBroadcastTab('rootPopupRequestInformationBroadcast'); +    const {popupId, frameId} = await rootPopupInformationPromise; + +    const getFrameOffset = frameOffsetForwarder.getOffset.bind(frameOffsetForwarder); + +    const popup = new PopupProxy(popupId, 0, null, frameId, url, getFrameOffset); +    await popup.prepare(); + +    return popup; +} + +async function getOrCreatePopup(depth) { +    const popupHost = new PopupProxyHost(); +    await popupHost.prepare(); + +    const popup = popupHost.getOrCreatePopup(null, null, depth); + +    return popup; +} + +async function createPopupProxy(depth, id, parentFrameId, url) { +    const popup = new PopupProxy(null, depth + 1, id, parentFrameId, url); +    await popup.prepare(); + +    return popup; +} +  async function main() {      await yomichan.prepare();      const data = window.frontendInitializationData || {}; -    const {id, depth=0, parentFrameId, url, proxy=false} = data; - -    const optionsContext = {depth, url}; -    const options = await apiOptionsGet(optionsContext); - -    let popup; -    if (!proxy && (window !== window.parent) && options.general.showIframePopupsInRootFrame) { -        const rootPopupInformationPromise = yomichan.getTemporaryListenerResult( -            chrome.runtime.onMessage, -            ({action, params}, {resolve}) => { -                if (action === 'rootPopupInformation') { -                    resolve(params); -                } +    const {id, depth=0, parentFrameId, url=window.location.href, proxy=false, isSearchPage=false} = data; + +    const isIframe = !proxy && (window !== window.parent); + +    const popups = { +        iframe: null, +        proxy: null, +        normal: null +    }; + +    let frontend = null; +    let frontendPreparePromise = null; +    let frameOffsetForwarder = null; + +    const applyOptions = async () => { +        const optionsContext = {depth: isSearchPage ? 0 : depth, url}; +        const options = await apiOptionsGet(optionsContext); + +        if (!proxy && frameOffsetForwarder === null) { +            frameOffsetForwarder = new FrameOffsetForwarder(); +            frameOffsetForwarder.start(); +        } + +        let popup; +        if (isIframe && options.general.showIframePopupsInRootFrame) { +            popup = popups.iframe || await createIframePopupProxy(url, frameOffsetForwarder); +            popups.iframe = popup; +        } else if (proxy) { +            popup = popups.proxy || await createPopupProxy(depth, id, parentFrameId, url); +            popups.proxy = popup; +        } else { +            popup = popups.normal || await getOrCreatePopup(depth); +            popups.normal = popup; +        } + +        if (frontend === null) { +            frontend = new Frontend(popup); +            frontendPreparePromise = frontend.prepare(); +            await frontendPreparePromise; +        } else { +            await frontendPreparePromise; +            if (isSearchPage) { +                const disabled = !options.scanning.enableOnSearchPage; +                frontend.setDisabledOverride(disabled); +            } + +            if (isIframe) { +                await frontend.setPopup(popup);              } -        ); -        apiBroadcastTab('rootPopupRequestInformationBroadcast'); -        const {popupId, frameId} = await rootPopupInformationPromise; - -        const frameOffsetForwarder = new FrameOffsetForwarder(); -        frameOffsetForwarder.start(); -        const getFrameOffset = frameOffsetForwarder.getOffset.bind(frameOffsetForwarder); - -        popup = new PopupProxy(popupId, 0, null, frameId, url, getFrameOffset); -        await popup.prepare(); -    } else if (proxy) { -        popup = new PopupProxy(null, depth + 1, id, parentFrameId, url); -        await popup.prepare(); -    } else { -        const frameOffsetForwarder = new FrameOffsetForwarder(); -        frameOffsetForwarder.start(); - -        const popupHost = new PopupProxyHost(); -        await popupHost.prepare(); - -        popup = popupHost.getOrCreatePopup(null, null, depth); -    } - -    const frontend = new Frontend(popup); -    await frontend.prepare(); +        } +    }; + +    yomichan.on('optionsUpdated', applyOptions); + +    await applyOptions();  }  main(); diff --git a/ext/fg/js/frontend.js b/ext/fg/js/frontend.js index 95427c4c..eecfe2e1 100644 --- a/ext/fg/js/frontend.js +++ b/ext/fg/js/frontend.js @@ -29,11 +29,14 @@ class Frontend extends TextScanner {      constructor(popup) {          super(              window, -            popup.isProxy() ? [] : [popup.getContainer()], +            () => this.popup.isProxy() ? [] : [this.popup.getContainer()],              [(x, y) => this.popup.containsPoint(x, y)]          );          this.popup = popup; + +        this._disabledOverride = false; +          this.options = null;          this.optionsContext = { @@ -132,8 +135,20 @@ class Frontend extends TextScanner {          ];      } +    setDisabledOverride(disabled) { +        this._disabledOverride = disabled; +        this.setEnabled(this.options.general.enable, this._canEnable()); +    } + +    async setPopup(popup) { +        this.onSearchClear(false); +        this.popup = popup; +        await popup.setOptions(this.options); +    } +      async updateOptions() { -        this.setOptions(await apiOptionsGet(this.getOptionsContext())); +        this.options = await apiOptionsGet(this.getOptionsContext()); +        this.setOptions(this.options, this._canEnable());          const ignoreNodes = ['.scan-disable', '.scan-disable *'];          if (!this.options.scanning.enableOnPopupExpressions) { @@ -259,7 +274,7 @@ class Frontend extends TextScanner {      }      _broadcastRootPopupInformation() { -        if (!this.popup.isProxy() && this.popup.depth === 0) { +        if (!this.popup.isProxy() && this.popup.depth === 0 && this.popup.frameId === 0) {              apiBroadcastTab('rootPopupInformation', {popupId: this.popup.id, frameId: this.popup.frameId});          }      } @@ -272,6 +287,10 @@ class Frontend extends TextScanner {          });      } +    _canEnable() { +        return this.popup.depth <= this.options.scanning.popupNestingMaxDepth && !this._disabledOverride; +    } +      async _updatePopupPosition() {          const textSource = this.getCurrentTextSource();          if (textSource !== null && await this.popup.isVisible()) { diff --git a/ext/fg/js/popup-nested.js b/ext/fg/js/popup-nested.js index 1b24614b..c140f9c8 100644 --- a/ext/fg/js/popup-nested.js +++ b/ext/fg/js/popup-nested.js @@ -19,24 +19,7 @@   * apiOptionsGet   */ -let popupNestedInitialized = false; - -async function popupNestedInitialize(id, depth, parentFrameId, url) { -    if (popupNestedInitialized) { -        return; -    } -    popupNestedInitialized = true; - -    const optionsContext = {depth, url}; -    const options = await apiOptionsGet(optionsContext); -    const popupNestingMaxDepth = options.scanning.popupNestingMaxDepth; - -    if (!(typeof popupNestingMaxDepth === 'number' && typeof depth === 'number' && depth < popupNestingMaxDepth)) { -        return; -    } - -    window.frontendInitializationData = {id, depth, parentFrameId, url, proxy: true}; - +function injectPopupNested() {      const scriptSrcs = [          '/mixed/js/text-scanner.js',          '/fg/js/frontend-api-sender.js', @@ -52,3 +35,33 @@ async function popupNestedInitialize(id, depth, parentFrameId, url) {          document.body.appendChild(script);      }  } + +async function popupNestedInitialize(id, depth, parentFrameId, url) { +    let optionsApplied = false; + +    const applyOptions = async () => { +        const optionsContext = {depth, url}; +        const options = await apiOptionsGet(optionsContext); +        const popupNestingMaxDepth = options.scanning.popupNestingMaxDepth; + +        const maxPopupDepthExceeded = !( +            typeof popupNestingMaxDepth === 'number' && +            typeof depth === 'number' && +            depth < popupNestingMaxDepth +        ); +        if (maxPopupDepthExceeded || optionsApplied) { +            return; +        } + +        optionsApplied = true; + +        window.frontendInitializationData = {id, depth, parentFrameId, url, proxy: true}; +        injectPopupNested(); + +        yomichan.off('optionsUpdated', applyOptions); +    }; + +    yomichan.on('optionsUpdated', applyOptions); + +    await applyOptions(); +} diff --git a/ext/fg/js/popup.js b/ext/fg/js/popup.js index 42f08afa..99610e17 100644 --- a/ext/fg/js/popup.js +++ b/ext/fg/js/popup.js @@ -539,19 +539,10 @@ class Popup {          };      } -    static _isOnExtensionPage() { -        try { -            const url = chrome.runtime.getURL('/'); -            return window.location.href.substring(0, url.length) === url; -        } catch (e) { -            // NOP -        } -    } -      static async _injectStylesheet(id, type, value, useWebExtensionApi) {          const injectedStylesheets = Popup._injectedStylesheets; -        if (Popup._isOnExtensionPage()) { +        if (yomichan.isExtensionUrl(window.location.href)) {              // Permissions error will occur if trying to use the WebExtension API to inject              // into an extension page.              useWebExtensionApi = false; diff --git a/ext/manifest.json b/ext/manifest.json index 788e1469..452b642c 100644 --- a/ext/manifest.json +++ b/ext/manifest.json @@ -1,7 +1,7 @@  {      "manifest_version": 2,      "name": "Yomichan", -    "version": "20.4.10.0", +    "version": "20.4.18.0",      "description": "Japanese dictionary with Anki integration",      "icons": {"16": "mixed/img/icon16.png", "48": "mixed/img/icon48.png", "128": "mixed/img/icon128.png"}, diff --git a/ext/mixed/js/api.js b/ext/mixed/js/api.js index 50b285a5..7080d93a 100644 --- a/ext/mixed/js/api.js +++ b/ext/mixed/js/api.js @@ -44,10 +44,6 @@ function apiTextParse(text, optionsContext) {      return _apiInvoke('textParse', {text, optionsContext});  } -function apiTextParseMecab(text, optionsContext) { -    return _apiInvoke('textParseMecab', {text, optionsContext}); -} -  function apiKanjiFind(text, optionsContext) {      return _apiInvoke('kanjiFind', {text, optionsContext});  } @@ -120,6 +116,30 @@ function apiGetDefaultAnkiFieldTemplates() {      return _apiInvoke('getDefaultAnkiFieldTemplates');  } +function apiGetAnkiDeckNames() { +    return _apiInvoke('getAnkiDeckNames'); +} + +function apiGetAnkiModelNames() { +    return _apiInvoke('getAnkiModelNames'); +} + +function apiGetAnkiModelFieldNames(modelName) { +    return _apiInvoke('getAnkiModelFieldNames', {modelName}); +} + +function apiGetDictionaryInfo() { +    return _apiInvoke('getDictionaryInfo'); +} + +function apiGetDictionaryCounts(dictionaryNames, getTotal) { +    return _apiInvoke('getDictionaryCounts', {dictionaryNames, getTotal}); +} + +function apiPurgeDatabase() { +    return _apiInvoke('purgeDatabase'); +} +  function _apiInvoke(action, params={}) {      const data = {action, params};      return new Promise((resolve, reject) => { diff --git a/ext/mixed/js/core.js b/ext/mixed/js/core.js index 2d11c11a..6a3298fc 100644 --- a/ext/mixed/js/core.js +++ b/ext/mixed/js/core.js @@ -316,6 +316,15 @@ const yomichan = (() => {              this.trigger('orphaned', {error});          } +        isExtensionUrl(url) { +            try { +                const urlBase = chrome.runtime.getURL('/'); +                return url.substring(0, urlBase.length) === urlBase; +            } catch (e) { +                return false; +            } +        } +          getTemporaryListenerResult(eventHandler, userCallback, timeout=null) {              if (!(                  typeof eventHandler.addListener === 'function' && diff --git a/ext/mixed/js/text-scanner.js b/ext/mixed/js/text-scanner.js index e6b9a2e6..0cd12cd7 100644 --- a/ext/mixed/js/text-scanner.js +++ b/ext/mixed/js/text-scanner.js @@ -46,7 +46,7 @@ class TextScanner {      }      onMouseOver(e) { -        if (this.ignoreElements.includes(e.target)) { +        if (this.ignoreElements().includes(e.target)) {              this.scanTimerClear();          }      } @@ -224,8 +224,8 @@ class TextScanner {          }      } -    setEnabled(enabled) { -        if (enabled) { +    setEnabled(enabled, canEnable) { +        if (enabled && canEnable) {              if (!this.enabled) {                  this.hookEvents();                  this.enabled = true; @@ -271,9 +271,9 @@ class TextScanner {          ];      } -    setOptions(options) { +    setOptions(options, canEnable=true) {          this.options = options; -        this.setEnabled(this.options.general.enable); +        this.setEnabled(this.options.general.enable, canEnable);      }      async searchAt(x, y, cause) { |