diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2020-11-23 15:23:47 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-23 15:23:47 -0500 |
| commit | 01ff7436ee381c4414e95572cff08aac999b7721 (patch) | |
| tree | cf5fc7fffdcec77f7dc3996ece0d35b227c9f8c6 /ext/mixed | |
| parent | 2971f262f9851d588f815d5ea03de69f9594de5a (diff) | |
Popup setup refactoring (#1054)
* Pass childrenSupported as a parameter to Frontend/Popup constructors
* Remove setChildrenSupported
* Use event listener instead of function override
* Update options order
* Expand options and use object for clarity
* Fix childrenSupported not being fully propagated
Diffstat (limited to 'ext/mixed')
| -rw-r--r-- | ext/mixed/js/display.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ext/mixed/js/display.js b/ext/mixed/js/display.js index 8b755b83..0bbdf730 100644 --- a/ext/mixed/js/display.js +++ b/ext/mixed/js/display.js @@ -1704,7 +1704,8 @@ class Display extends EventDispatcher { frameId, popupFactory, pageType: this._pageType, - allowRootFramePopupProxy: true + allowRootFramePopupProxy: true, + childrenSupported: this._childrenSupported }); const frontend = new Frontend(setupNestedPopupsOptions); |