prevent accidental lookup on glossary text select

1 files changed, 20 insertions, 1 deletions

diff --git a/ext/mixed/js/display.js b/ext/mixed/js/display.js
index bdc5e962..81072957 100644
--- a/ext/mixed/js/display.js
+++ b/ext/mixed/js/display.js
@@ -35,6 +35,7 @@ class Display {
         this.persistentEventListeners = [];
         this.interactive = false;
         this.eventListenersActive = false;
+        this.clickScanPrevent = false;
 
         this.windowScroll = new WindowScroll();
 
@@ -81,6 +82,22 @@ class Display {
         }
     }
 
+    onGlossaryMousedown(e) {
+        if (Frontend.isMouseButton('primary', e)) {
+            this.clickScanPrevent = false;
+        }
+    }
+
+    onGlossaryMouseMove(e) {
+        this.clickScanPrevent = true;
+    }
+
+    onGlossaryMouseup(e) {
+        if (!this.clickScanPrevent && Frontend.isMouseButton('primary', e)) {
+            this.onTermLookup(e);
+        }
+    }
+
     async onTermLookup(e) {
         try {
             e.preventDefault();
@@ -252,7 +269,9 @@ class Display {
             this.addEventListeners('.kanji-link', 'click', this.onKanjiLookup.bind(this));
             this.addEventListeners('.source-term', 'click', this.onSourceTermView.bind(this));
             if (this.options.scanning.enablePopupSearch) {
-                this.addEventListeners('.glossary-item', 'click', this.onTermLookup.bind(this));
+                this.addEventListeners('.glossary-item', 'mouseup', this.onGlossaryMouseup.bind(this));
+                this.addEventListeners('.glossary-item', 'mousedown', this.onGlossaryMousedown.bind(this));
+                this.addEventListeners('.glossary-item', 'mousemove', this.onGlossaryMouseMove.bind(this));
             }
         } else {
             Display.clearEventListeners(this.eventListeners);