summaryrefslogtreecommitdiff
path: root/ext/mixed/js
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2020-12-05 17:45:45 -0500
committerGitHub <noreply@github.com>2020-12-05 17:45:45 -0500
commit95b225462ad50af31da104427d61aff3597a8244 (patch)
tree94818f864910b9a4eb12067c4bde23805ed4a9d4 /ext/mixed/js
parentae9a20e0de61bbb84ec359004a401d9f2705aeea (diff)
Fix frequency tags (#1080)
* Rename term-frequency to tag-frequency * Move tag styles * Expand * Use separate templates for terms vs kanji
Diffstat (limited to 'ext/mixed/js')
-rw-r--r--ext/mixed/js/display-generator.js32
1 files changed, 23 insertions, 9 deletions
diff --git a/ext/mixed/js/display-generator.js b/ext/mixed/js/display-generator.js
index 82f6199b..1810000b 100644
--- a/ext/mixed/js/display-generator.js
+++ b/ext/mixed/js/display-generator.js
@@ -80,7 +80,7 @@ class DisplayGenerator {
this._appendMultiple(expressionsContainer, this._createTermExpression.bind(this), expressions);
this._appendMultiple(reasonsContainer, this._createTermReason.bind(this), reasons);
- this._appendMultiple(frequenciesContainer, this._createFrequencyTag.bind(this), frequencies);
+ this._appendMultiple(frequenciesContainer, this._createTermFrequencyTag.bind(this), frequencies);
this._appendMultiple(pitchesContainer, this._createPitches.bind(this), pitches);
this._appendMultiple(definitionsContainer, this._createTermDefinitionItem.bind(this), definitions);
@@ -103,7 +103,7 @@ class DisplayGenerator {
glyphContainer.textContent = details.character;
- this._appendMultiple(frequenciesContainer, this._createFrequencyTag.bind(this), details.frequencies);
+ this._appendMultiple(frequenciesContainer, this._createKanjiFrequencyTag.bind(this), details.frequencies);
this._appendMultiple(tagContainer, this._createTag.bind(this), details.tags);
this._appendMultiple(glossaryContainer, this._createKanjiGlossaryItem.bind(this), details.glossary);
this._appendMultiple(chineseReadingsContainer, this._createKanjiReading.bind(this), details.onyomi);
@@ -138,7 +138,7 @@ class DisplayGenerator {
this._appendFurigana(expressionContainer, furiganaSegments, this._appendKanjiLinks.bind(this));
this._appendMultiple(tagContainer, this._createTag.bind(this), termTags);
this._appendMultiple(tagContainer, this._createSearchTag.bind(this), searchQueries);
- this._appendMultiple(frequencyContainer, this._createFrequencyTag.bind(this), frequencies);
+ this._appendMultiple(frequencyContainer, this._createTermFrequencyTag.bind(this), frequencies);
return node;
}
@@ -458,14 +458,14 @@ class DisplayGenerator {
path.setAttribute('d', `M${pathPoints.join(' L')}`);
}
- _createFrequencyTag(details) {
+ _createTermFrequencyTag(details) {
const {expression, reading, dictionary, frequency} = details;
- const node = this._templates.instantiate('tag-frequency');
+ const node = this._templates.instantiate('term-tag-frequency');
- node.querySelector('.term-frequency-disambiguation-expression').textContent = expression;
- node.querySelector('.term-frequency-disambiguation-reading').textContent = reading;
- node.querySelector('.term-frequency-dictionary-name').textContent = dictionary;
- node.querySelector('.term-frequency-value').textContent = frequency;
+ node.querySelector('.tag-frequency-disambiguation-expression').textContent = expression;
+ node.querySelector('.tag-frequency-disambiguation-reading').textContent = reading;
+ node.querySelector('.tag-frequency-dictionary-name').textContent = dictionary;
+ node.querySelector('.tag-frequency-value').textContent = frequency;
node.dataset.expression = expression;
node.dataset.reading = reading;
@@ -476,6 +476,20 @@ class DisplayGenerator {
return node;
}
+ _createKanjiFrequencyTag(details) {
+ const {character, dictionary, frequency} = details;
+ const node = this._templates.instantiate('kanji-tag-frequency');
+
+ node.querySelector('.tag-frequency-dictionary-name').textContent = dictionary;
+ node.querySelector('.tag-frequency-value').textContent = frequency;
+
+ node.dataset.character = character;
+ node.dataset.dictionary = dictionary;
+ node.dataset.frequency = frequency;
+
+ return node;
+ }
+
_appendKanjiLinks(container, text) {
const jp = this._japaneseUtil;
let part = '';