Extension unload indication fix (#662)

* Remove unused function

* Rename field

* Change extensionUnloaded trigger function

* Update how extension unloaded content is shown

* Ignore certain errors caused by extension unload

* Add _showExtensionUnloaded function

* Wrap internals of updateOptions

* Suppress errors caued by extension unload

* Make the frontend trigger the popup's extensionUnloaded event

1 files changed, 6 insertions, 6 deletions

diff --git a/ext/mixed/js/yomichan.js b/ext/mixed/js/yomichan.js
index 7fffbaa6..33870658 100644
--- a/ext/mixed/js/yomichan.js
+++ b/ext/mixed/js/yomichan.js
@@ -196,7 +196,7 @@ const yomichan = (() => {
             try {
                 return chrome.runtime.sendMessage(...args);
             } catch (e) {
-                this._onExtensionUnloaded(e);
+                this.triggerExtensionUnloaded();
                 throw e;
             }
         }
@@ -205,7 +205,7 @@ const yomichan = (() => {
             try {
                 return chrome.runtime.connect(...args);
             } catch (e) {
-                this._onExtensionUnloaded(e);
+                this.triggerExtensionUnloaded();
                 throw e;
             }
         }
@@ -247,13 +247,13 @@ const yomichan = (() => {
             }
         }
 
-        // Private
-
-        _onExtensionUnloaded(error) {
+        triggerExtensionUnloaded() {
             this._isExtensionUnloaded = true;
-            this.trigger('extensionUnloaded', {error});
+            this.trigger('extensionUnloaded');
         }
 
+        // Private
+
         _getUrl() {
             return (typeof window === 'object' && window !== null ? window.location.href : '');
         }