diff options
author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2021-01-17 23:05:15 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-01-17 23:05:15 -0500 |
commit | 887150e01257af0b5deb472263de116cac7d0c1c (patch) | |
tree | ab3b17be658da6209d7c497ca956762a45354228 /ext/mixed/js/display.js | |
parent | d21de9df0052d89bea09e947c312e3694cc64920 (diff) |
Audio system improvements (#1268)
* Simplify API
* Move fallback audio
Diffstat (limited to 'ext/mixed/js/display.js')
-rw-r--r-- | ext/mixed/js/display.js | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/ext/mixed/js/display.js b/ext/mixed/js/display.js index 3c7deefe..0b0236da 100644 --- a/ext/mixed/js/display.js +++ b/ext/mixed/js/display.js @@ -46,10 +46,7 @@ class Display extends EventDispatcher { this._options = null; this._index = 0; this._audioPlaying = null; - this._audioFallback = null; - this._audioSystem = new AudioSystem({ - getAudioInfo: this._getAudioInfo.bind(this) - }); + this._audioSystem = new AudioSystem(true); this._styleNode = null; this._eventListeners = new EventListenerCollection(); this._setContentToken = null; @@ -1234,10 +1231,7 @@ class Display extends EventDispatcher { ({audio, index} = await this._audioSystem.createDefinitionAudio(sources, expression, reading, {textToSpeechVoice, customSourceUrl})); info = `From source ${1 + index}: ${sources[index]}`; } catch (e) { - if (this._audioFallback === null) { - this._audioFallback = new Audio('/mixed/mp3/button.mp3'); - } - audio = this._audioFallback; + audio = this._audioSystem.getFallbackAudio(); info = 'Could not find audio'; } @@ -1569,10 +1563,6 @@ class Display extends EventDispatcher { return {type, expression, reading}; } - async _getAudioInfo(source, expression, reading, details) { - return await api.getDefinitionAudioInfo(source, expression, reading, details); - } - async _setOptionsContextIfDifferent(optionsContext) { if (deepEqual(this._optionsContext, optionsContext)) { return; } await this.setOptionsContext(optionsContext); |