aboutsummaryrefslogtreecommitdiff
path: root/ext/js
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2021-05-23 14:30:31 -0400
committerGitHub <noreply@github.com>2021-05-23 14:30:31 -0400
commit8e330d54d6bca67b06a6afda3119b0e4bded41e6 (patch)
treec7857621f2af0b1c59ff080d4f7bc604ff07813a /ext/js
parent5188e49cd47af95b3e854349b9352e790b9c0cd2 (diff)
Fix popup preview disappearing after changing a setting (#1707)
Diffstat (limited to 'ext/js')
-rw-r--r--ext/js/app/frontend.js1
-rw-r--r--ext/js/language/text-scanner.js4
2 files changed, 5 insertions, 0 deletions
diff --git a/ext/js/app/frontend.js b/ext/js/app/frontend.js
index e40b400d..1c6def06 100644
--- a/ext/js/app/frontend.js
+++ b/ext/js/app/frontend.js
@@ -565,6 +565,7 @@ class Frontend {
_updateTextScannerEnabled() {
const enabled = (this._options !== null && this._options.general.enable && !this._disabledOverride);
+ if (enabled === this._textScanner.isEnabled()) { return; }
this._textScanner.setEnabled(enabled);
this._clearSelection(true);
}
diff --git a/ext/js/language/text-scanner.js b/ext/js/language/text-scanner.js
index 80887b8e..c7cedd7e 100644
--- a/ext/js/language/text-scanner.js
+++ b/ext/js/language/text-scanner.js
@@ -119,6 +119,10 @@ class TextScanner extends EventDispatcher {
this.setEnabled(this._enabled);
}
+ isEnabled() {
+ return this._enabled;
+ }
+
setEnabled(enabled) {
this._enabled = enabled;