diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2022-10-05 22:51:15 -0400 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-05 22:51:15 -0400 | 
| commit | abb3e5d5d0a63a20933f1770e03e87e756439d35 (patch) | |
| tree | 789bf4e69bad247ad9a535673c6ac9bdf079f9fe /ext/js | |
| parent | f76c7d74d076b53d2f17ef4d234d4fa894bbf611 (diff) | |
Audio certificate error notification (#2243)
* Refactor error throwing and change ID
* Show a notification when an audio download fails due to an expired cert
Diffstat (limited to 'ext/js')
| -rw-r--r-- | ext/js/background/backend.js | 15 | 
1 files changed, 10 insertions, 5 deletions
| diff --git a/ext/js/background/backend.js b/ext/js/background/backend.js index 20402539..197734b1 100644 --- a/ext/js/background/backend.js +++ b/ext/js/background/backend.js @@ -1936,11 +1936,16 @@ class Backend {                      if (!isObject(error2.data)) { continue; }                      const {details} = error2.data;                      if (!isObject(details)) { continue; } -                    if (details.error === 'net::ERR_FAILED') { -                        // This is potentially an error due to the extension not having enough URL privileges. -                        // The message logged to the console looks like this: -                        //  Access to fetch at '<URL>' from origin 'chrome-extension://<ID>' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. -                        return this._createAudioDownloadError('Audio download failed due to possible extension permissions error', 'audio-download-failed', errors); +                    switch (details.error) { +                        case 'net::ERR_FAILED': +                            // This is potentially an error due to the extension not having enough URL privileges. +                            // The message logged to the console looks like this: +                            //  Access to fetch at '<URL>' from origin 'chrome-extension://<ID>' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. +                            return this._createAudioDownloadError('Audio download failed due to possible extension permissions error', 'audio-download-failed-permissions-error', errors); +                        case 'net::ERR_CERT_DATE_INVALID': // Chrome +                        case 'Peer’s Certificate has expired.': // Firefox +                            // This error occurs when a server certificate expires. +                            return this._createAudioDownloadError('Audio download failed due to an expired server certificate', 'audio-download-failed-expired-server-certificate', errors);                      }                  }              } |