diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2024-02-20 10:13:57 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-20 15:13:57 +0000 |
| commit | fe875bbd99980b175fc366a2bfd4395be9cbad72 (patch) | |
| tree | 9eacc919cae0aa32c1a5e25b8493a0e86a21f16e /ext/js/pages | |
| parent | 0e4ae922451af967c78616057ed26b85ba5d4b5c (diff) | |
Constructor simplification (#713)
* Update AudioDownloader
* Update Translator
* Update ClipboardMonitor
* Update ClipboardReader
* Update PanelElement
* Update QueryParser
* Update DisplayGenerator
* Update DisplayHistory
* Update DOMDataBinder
* Remove unnecessary cast
* Update Popup types
* One declaration per line
* Remove optionals from Frontend constructor
* Fix Translator constructor
Diffstat (limited to 'ext/js/pages')
| -rw-r--r-- | ext/js/pages/settings/generic-setting-controller.js | 14 | ||||
| -rw-r--r-- | ext/js/pages/settings/modal.js | 5 | ||||
| -rw-r--r-- | ext/js/pages/settings/status-footer.js | 5 |
3 files changed, 9 insertions, 15 deletions
diff --git a/ext/js/pages/settings/generic-setting-controller.js b/ext/js/pages/settings/generic-setting-controller.js index 54d87f8d..812520e4 100644 --- a/ext/js/pages/settings/generic-setting-controller.js +++ b/ext/js/pages/settings/generic-setting-controller.js @@ -31,13 +31,13 @@ export class GenericSettingController { /** @type {import('settings-modifications').OptionsScopeType} */ this._defaultScope = 'profile'; /** @type {DOMDataBinder<import('generic-setting-controller').ElementMetadata>} */ - this._dataBinder = new DOMDataBinder({ - selector: '[data-setting]', - createElementMetadata: this._createElementMetadata.bind(this), - compareElementMetadata: this._compareElementMetadata.bind(this), - getValues: this._getValues.bind(this), - setValues: this._setValues.bind(this) - }); + this._dataBinder = new DOMDataBinder( + '[data-setting]', + this._createElementMetadata.bind(this), + this._compareElementMetadata.bind(this), + this._getValues.bind(this), + this._setValues.bind(this) + ); /** @type {Map<import('generic-setting-controller').TransformType, import('generic-setting-controller').TransformFunction>} */ this._transforms = new Map(/** @type {[key: import('generic-setting-controller').TransformType, value: import('generic-setting-controller').TransformFunction][]} */ ([ ['setAttribute', this._setAttribute.bind(this)], diff --git a/ext/js/pages/settings/modal.js b/ext/js/pages/settings/modal.js index 7e20dcb4..1eee00d7 100644 --- a/ext/js/pages/settings/modal.js +++ b/ext/js/pages/settings/modal.js @@ -23,10 +23,7 @@ export class Modal extends PanelElement { * @param {HTMLElement} node */ constructor(node) { - super({ - node, - closingAnimationDuration: 375 // Milliseconds; includes buffer - }); + super(node, 375); // Milliseconds; includes buffer /** @type {?Element} */ this._contentNode = null; /** @type {boolean} */ diff --git a/ext/js/pages/settings/status-footer.js b/ext/js/pages/settings/status-footer.js index 786e1d55..420dd044 100644 --- a/ext/js/pages/settings/status-footer.js +++ b/ext/js/pages/settings/status-footer.js @@ -24,10 +24,7 @@ export class StatusFooter extends PanelElement { * @param {HTMLElement} node */ constructor(node) { - super({ - node, - closingAnimationDuration: 375 // Milliseconds; includes buffer - }); + super(node, 375); // Milliseconds; includes buffer /** @type {HTMLElement} */ this._body = querySelectorNotNull(node, '.status-footer'); } |