diff options
author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2024-02-18 07:58:59 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-18 12:58:59 +0000 |
commit | 7e9f7e2616973418cc50f7706bd8f644cb9d5559 (patch) | |
tree | 8f8bec7a777a2df33a0a26ef53022c50d2327ef8 /ext/js/pages/settings/popup-preview-frame.js | |
parent | 4aaa9f15d97668203741c1731f15e710ae8b8294 (diff) |
Application data refactor (#699)
* Pass tabId and frameId to Application
* Remove casts
* Remove redundant frameInformationGet calls
* Expose tabId and frameId
* Remove unsed
* Simplify
* Update FrameAncestryHandler to not need a direct frameId
* Remove frameId from FrameOffsetForwarder
* Remove frameId from PopupFactory
* Remove frameId from Frontend
* Remove frameId from PopupPreviewFrame
* Fix PopupFactory and Frontend constructor
* Remove frameId from Display
* Remove frameId from SearchDisplayController
* Restore if check
Diffstat (limited to 'ext/js/pages/settings/popup-preview-frame.js')
-rw-r--r-- | ext/js/pages/settings/popup-preview-frame.js | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/ext/js/pages/settings/popup-preview-frame.js b/ext/js/pages/settings/popup-preview-frame.js index 1ad4859b..2898eaa2 100644 --- a/ext/js/pages/settings/popup-preview-frame.js +++ b/ext/js/pages/settings/popup-preview-frame.js @@ -24,18 +24,12 @@ import {TextSourceRange} from '../../dom/text-source-range.js'; export class PopupPreviewFrame { /** * @param {import('../../application.js').Application} application - * @param {number} tabId - * @param {number} frameId * @param {import('../../app/popup-factory.js').PopupFactory} popupFactory * @param {import('../../input/hotkey-handler.js').HotkeyHandler} hotkeyHandler */ - constructor(application, tabId, frameId, popupFactory, hotkeyHandler) { + constructor(application, popupFactory, hotkeyHandler) { /** @type {import('../../application.js').Application} */ this._application = application; - /** @type {number} */ - this._tabId = tabId; - /** @type {number} */ - this._frameId = frameId; /** @type {import('../../app/popup-factory.js').PopupFactory} */ this._popupFactory = popupFactory; /** @type {import('../../input/hotkey-handler.js').HotkeyHandler} */ @@ -94,8 +88,6 @@ export class PopupPreviewFrame { // Overwrite frontend this._frontend = new Frontend({ application: this._application, - tabId: this._tabId, - frameId: this._frameId, popupFactory: this._popupFactory, depth: 0, parentPopupId: null, |