summaryrefslogtreecommitdiff
path: root/ext/js/pages/settings/dictionary-controller.js
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2021-03-31 18:17:28 -0400
committerGitHub <noreply@github.com>2021-03-31 18:17:28 -0400
commitbcbd413e571d772a4438f57138169ad1a6a3b5a8 (patch)
treee8768f5e91e62759e2dce7179359aa83ff6e4d0f /ext/js/pages/settings/dictionary-controller.js
parentcbcfdcacaf68efb09e47932f5b14881b982aecd2 (diff)
Definition collapsing when overflowing (#1575)
* Add double-down-chevron.svg * Add options * Update dictionary importers * Update settings * Add support for collapsible definitions * Improve case when there is a very small amount of overflow * Fix incorrect enabled state of newly imported dictionaries
Diffstat (limited to 'ext/js/pages/settings/dictionary-controller.js')
-rw-r--r--ext/js/pages/settings/dictionary-controller.js19
1 files changed, 10 insertions, 9 deletions
diff --git a/ext/js/pages/settings/dictionary-controller.js b/ext/js/pages/settings/dictionary-controller.js
index 17abfa13..65edcb67 100644
--- a/ext/js/pages/settings/dictionary-controller.js
+++ b/ext/js/pages/settings/dictionary-controller.js
@@ -248,6 +248,15 @@ class DictionaryController {
this._updateDictionariesEnabledWarnings(options);
}
+ static createDefaultDictionarySettings(enabled) {
+ return {
+ priority: 0,
+ enabled,
+ allowSecondarySearches: false,
+ definitionsCollapsible: 'not-collapsible'
+ };
+ }
+
// Private
_onOptionsChanged({options}) {
@@ -535,7 +544,7 @@ class DictionaryController {
targets.push({
action: 'set',
path,
- value: DictionaryController.createDefaultDictionarySettings()
+ value: DictionaryController.createDefaultDictionarySettings(false)
});
}
}
@@ -548,12 +557,4 @@ class DictionaryController {
_triggerStorageChanged() {
yomichan.trigger('storageChanged');
}
-
- static createDefaultDictionarySettings() {
- return {
- enabled: false,
- allowSecondarySearches: false,
- priority: 0
- };
- }
}