diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2023-12-16 19:55:02 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-17 00:55:02 +0000 |
| commit | 95ad1ae1ef4a53802c12eab4c9b1545af0333aa1 (patch) | |
| tree | c08016ccb3265a5931baf413cd9d78fcbf600ae9 /ext/js/pages/permissions-main.js | |
| parent | 77d27113d347b4724302f1c72de1f238e04aeead (diff) | |
Safer query selector (#364)
* Add querySelectorNotNull helper function
* Use querySelectorNotNull
* Updates
* Update settings
* Remove unused
* Update
* Update function calls
* More updates
* Update types
* Remove obsolete code
Diffstat (limited to 'ext/js/pages/permissions-main.js')
| -rw-r--r-- | ext/js/pages/permissions-main.js | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/ext/js/pages/permissions-main.js b/ext/js/pages/permissions-main.js index 064e9240..58dae310 100644 --- a/ext/js/pages/permissions-main.js +++ b/ext/js/pages/permissions-main.js @@ -18,6 +18,7 @@ import {log, promiseTimeout} from '../core.js'; import {DocumentFocusController} from '../dom/document-focus-controller.js'; +import {querySelectorNotNull} from '../dom/query-selector.js'; import {yomitan} from '../yomitan.js'; import {ExtensionContentController} from './common/extension-content-controller.js'; import {ModalController} from './settings/modal-controller.js'; @@ -99,11 +100,12 @@ function setupPermissionsToggles() { setupEnvironmentInfo(); - /** @type {[HTMLInputElement, HTMLInputElement]} */ - const permissionsCheckboxes = [ - /** @type {HTMLInputElement} */ (document.querySelector('#permission-checkbox-allow-in-private-windows')), - /** @type {HTMLInputElement} */ (document.querySelector('#permission-checkbox-allow-file-url-access')) - ]; + /** @type {HTMLInputElement} */ + const permissionCheckbox1 = querySelectorNotNull(document, '#permission-checkbox-allow-in-private-windows'); + /** @type {HTMLInputElement} */ + const permissionCheckbox2 = querySelectorNotNull(document, '#permission-checkbox-allow-file-url-access'); + /** @type {HTMLInputElement[]} */ + const permissionsCheckboxes = [permissionCheckbox1, permissionCheckbox2]; const permissions = await Promise.all([ isAllowedIncognitoAccess(), |