diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2022-05-16 21:45:22 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-16 21:45:22 -0400 |
| commit | 63d37c872b786abe9233d70b2eff0362582cbc3a (patch) | |
| tree | e3fd32f96b3734070876e8623acacc76666a0edf /ext/js/dom/text-source-element.js | |
| parent | 96f5a06c80b985a503a1e30e2cb6d346cb361aba (diff) | |
Popup positioning improvements (#2135)
* Rename elementRect to sourceRect
* Add getRects function to TextSourceElement and TextSourceRange
* Add jsdocs
* Remove unnecessary valid parameter
* Remove default parameter
* Make optionsContext optional
* Remove unnecessary checks
* Update sourceRect to use left/right rather than x/y
* Update the return type of Popup*.getFrameRect
* Rename some unrelated rect vars for disambiguation
* Disambiguate between Popup.Rect and Popup.ValidRect
* Move sourceRect destructuring
* Pass multiple source rects
* Simplify
* Change Rect to use right/bottom rather than width/height
* Update how popup offset is applied
* Simplify frame offset
* Remove _applyFrameOffset
* Use right/bottom rather than width/height
* Simplify some positioning settings
* Update parameter names for clarity
* Fix typos
* Refactor data type for _getPosition* functions
* Support using multiple source rects
* Combine _getPosition functions
* Refactor
* Expose after dataset value
* Consistently use this's property
* Add jsdoc
Diffstat (limited to 'ext/js/dom/text-source-element.js')
| -rw-r--r-- | ext/js/dom/text-source-element.js | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ext/js/dom/text-source-element.js b/ext/js/dom/text-source-element.js index 38b29a4c..1a842310 100644 --- a/ext/js/dom/text-source-element.js +++ b/ext/js/dom/text-source-element.js @@ -94,6 +94,10 @@ class TextSourceElement { return this._element.getBoundingClientRect(); } + getRects() { + return this.getClientRects(); + } + getWritingMode() { return 'horizontal-tb'; } |