Structured content auto language (#2131)

* Pass JapaneseUtil instance to StructuredContentGenerator

* Move body of createStructuredContent to an internal function

* Create _createStructuredContentGenericElement

* Wrap structured content in a <span>

* Change _createStructuredContent to _appendStructuredContent

* Add public appendStructuredContent function

* Add missing return

* Remove unused _createDocumentFragment

* Automatically assign lang=ja for content with Japanese characters
without an explicit language

* Add test

1 files changed, 3 insertions, 6 deletions

diff --git a/ext/js/display/display-generator.js b/ext/js/display/display-generator.js
index 1f485a4f..3fabdbb0 100644
--- a/ext/js/display/display-generator.js
+++ b/ext/js/display/display-generator.js
@@ -28,7 +28,7 @@ class DisplayGenerator {
         this._contentManager = contentManager;
         this._hotkeyHelpController = hotkeyHelpController;
         this._templates = null;
-        this._structuredContentGenerator = new StructuredContentGenerator(this._contentManager, document);
+        this._structuredContentGenerator = new StructuredContentGenerator(this._contentManager, japaneseUtil, document);
         this._pronunciationGenerator = new PronunciationGenerator(japaneseUtil);
     }
 
@@ -347,11 +347,8 @@ class DisplayGenerator {
 
     _createTermDefinitionEntryStructuredContent(content, dictionary) {
         const node = this._templates.instantiate('gloss-item');
-        const child = this._structuredContentGenerator.createStructuredContent(content, dictionary);
-        if (child !== null) {
-            const contentContainer = node.querySelector('.gloss-content');
-            contentContainer.appendChild(child);
-        }
+        const contentContainer = node.querySelector('.gloss-content');
+        this._structuredContentGenerator.appendStructuredContent(contentContainer, content, dictionary);
         return node;
     }