summaryrefslogtreecommitdiff
path: root/ext/js/data
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2024-02-14 22:26:29 -0500
committerGitHub <noreply@github.com>2024-02-15 03:26:29 +0000
commit6bf7b0055765c4f2011c9614753d6714dc09be65 (patch)
tree0e782ae66556eaa61a34d9f32d77c831b2443ce5 /ext/js/data
parent7a4096240ce4faf70a785d047945388baa0daab3 (diff)
Eslint rule updates (#673)
* Install unicorn * Add rules * Fix issues * Install sonarjs * Set up rules * Fix issues * Install eslint-plugin-import and fix import extensions * Simplify permitted error names
Diffstat (limited to 'ext/js/data')
-rw-r--r--ext/js/data/json-schema.js24
-rw-r--r--ext/js/data/permissions-util.js6
2 files changed, 14 insertions, 16 deletions
diff --git a/ext/js/data/json-schema.js b/ext/js/data/json-schema.js
index 3342e387..9e1497e9 100644
--- a/ext/js/data/json-schema.js
+++ b/ext/js/data/json-schema.js
@@ -27,6 +27,8 @@ export class JsonSchemaError extends Error {
*/
constructor(message, valueStack, schemaStack) {
super(message);
+ /** @type {string} */
+ this.name = 'JsonSchemaError';
/** @type {import('ext/json-schema').ValueStackItem[]} */
this._valueStack = valueStack;
/** @type {import('ext/json-schema').SchemaStackItem[]} */
@@ -371,18 +373,16 @@ export class JsonSchema {
return {schema, stack: [{schema, path: null}]};
}
const {prefixItems} = schema;
- if (typeof prefixItems !== 'undefined') {
- if (index >= 0 && index < prefixItems.length) {
- const itemSchema = prefixItems[index];
- if (typeof itemSchema !== 'undefined') {
- return {
- schema: itemSchema,
- stack: [
- {schema: prefixItems, path: 'prefixItems'},
- {schema: itemSchema, path: index}
- ]
- };
- }
+ if (typeof prefixItems !== 'undefined' && index >= 0 && index < prefixItems.length) {
+ const itemSchema = prefixItems[index];
+ if (typeof itemSchema !== 'undefined') {
+ return {
+ schema: itemSchema,
+ stack: [
+ {schema: prefixItems, path: 'prefixItems'},
+ {schema: itemSchema, path: index}
+ ]
+ };
}
}
const {items} = schema;
diff --git a/ext/js/data/permissions-util.js b/ext/js/data/permissions-util.js
index 837b6d5f..097fe34d 100644
--- a/ext/js/data/permissions-util.js
+++ b/ext/js/data/permissions-util.js
@@ -113,10 +113,8 @@ export function getRequiredPermissionsForAnkiFieldValue(fieldValue) {
export function hasRequiredPermissionsForOptions(permissions, options) {
const permissionsSet = new Set(permissions.permissions);
- if (!permissionsSet.has('nativeMessaging')) {
- if (options.parsing.enableMecabParser) {
- return false;
- }
+ if (!permissionsSet.has('nativeMessaging') && options.parsing.enableMecabParser) {
+ return false;
}
if (!permissionsSet.has('clipboardRead')) {