diff options
author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2024-02-25 11:20:44 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-25 16:20:44 +0000 |
commit | 2e9ea19207a7410f929bb908759d48cb2340f29c (patch) | |
tree | a6bde1297d693bb8d50e4c93a963aa3179e5a2ce /ext/js/comm | |
parent | 73169f06dff767020718a5715eba97d3575ba7e1 (diff) |
"isJapanese" check move (#730)
* Move isStringPartiallyJapanese out of ClipboardMonitor
* Create isStringPartiallyJapanese function
* Add textMayBeTranslatable
* Rename API function
* Rename internal function
* Add helper
* Update translatable check
* Pass language to TextScanner
* Pass language explicitly
* Use textMayBeTranslatable
* No redundant translatable check
* Update eslint
* Remove double newline
* Collapse
* Rename
Diffstat (limited to 'ext/js/comm')
-rw-r--r-- | ext/js/comm/api.js | 9 | ||||
-rw-r--r-- | ext/js/comm/clipboard-monitor.js | 3 |
2 files changed, 6 insertions, 6 deletions
diff --git a/ext/js/comm/api.js b/ext/js/comm/api.js index 30fcfc29..e8db7846 100644 --- a/ext/js/comm/api.js +++ b/ext/js/comm/api.js @@ -321,11 +321,12 @@ export class API { } /** - * @param {import('api').ApiParam<'textHasJapaneseCharacters', 'text'>} text - * @returns {Promise<import('api').ApiReturn<'textHasJapaneseCharacters'>>} + * @param {import('api').ApiParam<'isTextLookupWorthy', 'text'>} text + * @param {import('api').ApiParam<'isTextLookupWorthy', 'language'>} language + * @returns {Promise<import('api').ApiReturn<'isTextLookupWorthy'>>} */ - textHasJapaneseCharacters(text) { - return this._invoke('textHasJapaneseCharacters', {text}); + isTextLookupWorthy(text, language) { + return this._invoke('isTextLookupWorthy', {text, language}); } /** diff --git a/ext/js/comm/clipboard-monitor.js b/ext/js/comm/clipboard-monitor.js index d101b467..067ecb67 100644 --- a/ext/js/comm/clipboard-monitor.js +++ b/ext/js/comm/clipboard-monitor.js @@ -17,7 +17,6 @@ */ import {EventDispatcher} from '../core/event-dispatcher.js'; -import {isStringPartiallyJapanese} from '../language/ja/japanese.js'; /** * @augments EventDispatcher<import('clipboard-monitor').Events> @@ -71,7 +70,7 @@ export class ClipboardMonitor extends EventDispatcher { text !== this._previousText ) { this._previousText = text; - if (canChange && isStringPartiallyJapanese(text)) { + if (canChange) { this.trigger('change', {text}); } } |