diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2021-09-30 21:05:34 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-30 21:05:34 -0400 |
| commit | 19eb990aeb197f70a0cf46efdf9f2bdd6ed1d48c (patch) | |
| tree | 5215d2e1d669e4576cd5c345e400727de93999eb /ext/js/app/popup-proxy.js | |
| parent | 6cf01555e7ea8d8f795188d16b2de5df58d0a110 (diff) | |
DOMRect update (#1973)
* Compare using left/top rather than x/y
* Simplify
* Update Popup*.getFrameRect to return a custom structure
* Don't use x/y on DOMRect
Diffstat (limited to 'ext/js/app/popup-proxy.js')
| -rw-r--r-- | ext/js/app/popup-proxy.js | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/ext/js/app/popup-proxy.js b/ext/js/app/popup-proxy.js index 63ecc254..c46821d5 100644 --- a/ext/js/app/popup-proxy.js +++ b/ext/js/app/popup-proxy.js @@ -104,13 +104,9 @@ class PopupProxy extends EventDispatcher { async showContent(details, displayDetails) { const {elementRect} = details; - if (typeof elementRect !== 'undefined') { - let {x, y, width, height} = elementRect; - if (this._frameOffsetForwarder !== null) { - await this._updateFrameOffset(); - [x, y] = this._applyFrameOffset(x, y); - } - details.elementRect = {x, y, width, height}; + if (typeof elementRect !== 'undefined' && this._frameOffsetForwarder !== null) { + await this._updateFrameOffset(); + [elementRect.x, elementRect.y] = this._applyFrameOffset(elementRect.x, elementRect.y); } return await this._invokeSafe('showContent', {id: this._id, details, displayDetails}); } @@ -140,7 +136,7 @@ class PopupProxy extends EventDispatcher { } getFrameRect() { - return new DOMRect(0, 0, 0, 0); + return {x: 0, y: 0, width: 0, height: 0, valid: false}; } getFrameSize() { |