aboutsummaryrefslogtreecommitdiff
path: root/ext/fg/js
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2020-06-07 21:40:11 -0400
committerGitHub <noreply@github.com>2020-06-07 21:40:11 -0400
commit9767b765536279023045ed4280b12d297ec78f0a (patch)
tree672e5754ca6950dbca87e8aabc408ddeba21f9ae /ext/fg/js
parentb614aca3ddd04b9d533959b2eabaa6db43b79f8f (diff)
Use cross frame API (#553)
* Use new CrossFrameAPI for popup proxy communication * Remove use of old cross-frame communication classes * Remove use of old cross-frame communication files * Make the crossFrame object a member of the api object
Diffstat (limited to 'ext/fg/js')
-rw-r--r--ext/fg/js/float-main.js1
-rw-r--r--ext/fg/js/frontend-api-receiver.js76
-rw-r--r--ext/fg/js/frontend-api-sender.js128
-rw-r--r--ext/fg/js/popup-factory.js7
-rw-r--r--ext/fg/js/popup-proxy.js6
5 files changed, 6 insertions, 212 deletions
diff --git a/ext/fg/js/float-main.js b/ext/fg/js/float-main.js
index 249b4dbe..2ec334c8 100644
--- a/ext/fg/js/float-main.js
+++ b/ext/fg/js/float-main.js
@@ -24,7 +24,6 @@
async function injectPopupNested() {
await dynamicLoader.loadScripts([
'/mixed/js/text-scanner.js',
- '/fg/js/frontend-api-sender.js',
'/fg/js/popup.js',
'/fg/js/popup-proxy.js',
'/fg/js/frontend.js',
diff --git a/ext/fg/js/frontend-api-receiver.js b/ext/fg/js/frontend-api-receiver.js
deleted file mode 100644
index 3fa9e8b6..00000000
--- a/ext/fg/js/frontend-api-receiver.js
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- * Copyright (C) 2019-2020 Yomichan Authors
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <https://www.gnu.org/licenses/>.
- */
-
-
-class FrontendApiReceiver {
- constructor(source, messageHandlers) {
- this._source = source;
- this._messageHandlers = messageHandlers;
- }
-
- prepare() {
- chrome.runtime.onConnect.addListener(this._onConnect.bind(this));
- }
-
- _onConnect(port) {
- if (port.name !== 'frontend-api-receiver') { return; }
-
- port.onMessage.addListener(this._onMessage.bind(this, port));
- }
-
- _onMessage(port, {id, action, params, target, senderId}) {
- if (target !== this._source) { return; }
-
- const messageHandler = this._messageHandlers.get(action);
- if (typeof messageHandler === 'undefined') { return; }
-
- const {handler, async} = messageHandler;
-
- this._sendAck(port, id, senderId);
- if (async) {
- this._invokeHandlerAsync(handler, params, port, id, senderId);
- } else {
- this._invokeHandler(handler, params, port, id, senderId);
- }
- }
-
- _invokeHandler(handler, params, port, id, senderId) {
- try {
- const result = handler(params);
- this._sendResult(port, id, senderId, {result});
- } catch (error) {
- this._sendResult(port, id, senderId, {error: errorToJson(error)});
- }
- }
-
- async _invokeHandlerAsync(handler, params, port, id, senderId) {
- try {
- const result = await handler(params);
- this._sendResult(port, id, senderId, {result});
- } catch (error) {
- this._sendResult(port, id, senderId, {error: errorToJson(error)});
- }
- }
-
- _sendAck(port, id, senderId) {
- port.postMessage({type: 'ack', id, senderId});
- }
-
- _sendResult(port, id, senderId, data) {
- port.postMessage({type: 'result', id, senderId, data});
- }
-}
diff --git a/ext/fg/js/frontend-api-sender.js b/ext/fg/js/frontend-api-sender.js
deleted file mode 100644
index 4dcde638..00000000
--- a/ext/fg/js/frontend-api-sender.js
+++ /dev/null
@@ -1,128 +0,0 @@
-/*
- * Copyright (C) 2019-2020 Yomichan Authors
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <https://www.gnu.org/licenses/>.
- */
-
-
-class FrontendApiSender {
- constructor(target) {
- this._target = target;
- this._senderId = yomichan.generateId(16);
- this._ackTimeout = 3000; // 3 seconds
- this._responseTimeout = 10000; // 10 seconds
- this._callbacks = new Map();
- this._disconnected = false;
- this._nextId = 0;
- this._port = null;
- }
-
- invoke(action, params) {
- if (this._disconnected) {
- // attempt to reconnect the next time
- this._disconnected = false;
- return Promise.reject(new Error('Disconnected'));
- }
-
- if (this._port === null) {
- this._createPort();
- }
-
- const id = `${this._nextId}`;
- ++this._nextId;
-
- return new Promise((resolve, reject) => {
- const info = {id, resolve, reject, ack: false, timer: null};
- this._callbacks.set(id, info);
- info.timer = setTimeout(() => this._onError(id, 'Timeout (ack)'), this._ackTimeout);
-
- this._port.postMessage({id, action, params, target: this._target, senderId: this._senderId});
- });
- }
-
- _createPort() {
- this._port = chrome.runtime.connect(null, {name: 'backend-api-forwarder'});
- this._port.onDisconnect.addListener(this._onDisconnect.bind(this));
- this._port.onMessage.addListener(this._onMessage.bind(this));
- }
-
- _onMessage({type, id, data, senderId}) {
- if (senderId !== this._senderId) { return; }
- switch (type) {
- case 'ack':
- this._onAck(id);
- break;
- case 'result':
- this._onResult(id, data);
- break;
- }
- }
-
- _onDisconnect() {
- this._disconnected = true;
- this._port = null;
-
- for (const id of this._callbacks.keys()) {
- this._onError(id, 'Disconnected');
- }
- }
-
- _onAck(id) {
- const info = this._callbacks.get(id);
- if (typeof info === 'undefined') {
- yomichan.logWarning(new Error(`ID ${id} not found for ack`));
- return;
- }
-
- if (info.ack) {
- yomichan.logWarning(new Error(`Request ${id} already ack'd`));
- return;
- }
-
- info.ack = true;
- clearTimeout(info.timer);
- info.timer = setTimeout(() => this._onError(id, 'Timeout (response)'), this._responseTimeout);
- }
-
- _onResult(id, data) {
- const info = this._callbacks.get(id);
- if (typeof info === 'undefined') {
- yomichan.logWarning(new Error(`ID ${id} not found`));
- return;
- }
-
- if (!info.ack) {
- yomichan.logWarning(new Error(`Request ${id} not ack'd`));
- return;
- }
-
- this._callbacks.delete(id);
- clearTimeout(info.timer);
- info.timer = null;
-
- if (typeof data.error !== 'undefined') {
- info.reject(jsonToError(data.error));
- } else {
- info.resolve(data.result);
- }
- }
-
- _onError(id, reason) {
- const info = this._callbacks.get(id);
- if (typeof info === 'undefined') { return; }
- this._callbacks.delete(id);
- info.timer = null;
- info.reject(new Error(reason));
- }
-}
diff --git a/ext/fg/js/popup-factory.js b/ext/fg/js/popup-factory.js
index b10acbaf..b5997253 100644
--- a/ext/fg/js/popup-factory.js
+++ b/ext/fg/js/popup-factory.js
@@ -16,8 +16,8 @@
*/
/* global
- * FrontendApiReceiver
* Popup
+ * api
*/
class PopupFactory {
@@ -29,7 +29,7 @@ class PopupFactory {
// Public functions
async prepare() {
- const apiReceiver = new FrontendApiReceiver(`popup-factory#${this._frameId}`, new Map([
+ api.crossFrame.registerHandlers([
['getOrCreatePopup', {async: false, handler: this._onApiGetOrCreatePopup.bind(this)}],
['setOptionsContext', {async: true, handler: this._onApiSetOptionsContext.bind(this)}],
['hide', {async: false, handler: this._onApiHide.bind(this)}],
@@ -41,8 +41,7 @@ class PopupFactory {
['clearAutoPlayTimer', {async: false, handler: this._onApiClearAutoPlayTimer.bind(this)}],
['setContentScale', {async: false, handler: this._onApiSetContentScale.bind(this)}],
['getUrl', {async: false, handler: this._onApiGetUrl.bind(this)}]
- ]));
- apiReceiver.prepare();
+ ]);
}
getOrCreatePopup(id=null, parentId=null, depth=null) {
diff --git a/ext/fg/js/popup-proxy.js b/ext/fg/js/popup-proxy.js
index 82da839a..3387d941 100644
--- a/ext/fg/js/popup-proxy.js
+++ b/ext/fg/js/popup-proxy.js
@@ -16,7 +16,7 @@
*/
/* global
- * FrontendApiSender
+ * api
*/
class PopupProxy {
@@ -24,7 +24,7 @@ class PopupProxy {
this._id = id;
this._depth = depth;
this._parentPopupId = parentPopupId;
- this._apiSender = new FrontendApiSender(`popup-factory#${parentFrameId}`);
+ this._parentFrameId = parentFrameId;
this._getFrameOffset = getFrameOffset;
this._setDisabled = setDisabled;
@@ -111,7 +111,7 @@ class PopupProxy {
// Private
_invoke(action, params={}) {
- return this._apiSender.invoke(action, params);
+ return api.crossFrame.invoke(this._parentFrameId, action, params);
}
async _updateFrameOffset() {