Popup setup refactoring (#1054)

* Pass childrenSupported as a parameter to Frontend/Popup constructors

* Remove setChildrenSupported

* Use event listener instead of function override

* Update options order

* Expand options and use object for clarity

* Fix childrenSupported not being fully propagated

1 files changed, 6 insertions, 5 deletions

diff --git a/ext/fg/js/popup-window.js b/ext/fg/js/popup-window.js
index 1365211c..3d707a9e 100644
--- a/ext/fg/js/popup-window.js
+++ b/ext/fg/js/popup-window.js
@@ -20,7 +20,12 @@
  */
 
 class PopupWindow extends EventDispatcher {
-    constructor(id, depth, frameId, ownerFrameId) {
+    constructor({
+        id,
+        depth,
+        frameId,
+        ownerFrameId
+    }) {
         super();
         this._id = id;
         this._depth = depth;
@@ -123,10 +128,6 @@ class PopupWindow extends EventDispatcher {
         // NOP
     }
 
-    async setChildrenSupported(_value) {
-        // NOP
-    }
-
     getFrameRect() {
         return new DOMRect(0, 0, 0, 0);
     }