summaryrefslogtreecommitdiff
path: root/ext/fg/js/popup-window.js
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2020-11-23 15:23:47 -0500
committerGitHub <noreply@github.com>2020-11-23 15:23:47 -0500
commit01ff7436ee381c4414e95572cff08aac999b7721 (patch)
treecf5fc7fffdcec77f7dc3996ece0d35b227c9f8c6 /ext/fg/js/popup-window.js
parent2971f262f9851d588f815d5ea03de69f9594de5a (diff)
Popup setup refactoring (#1054)
* Pass childrenSupported as a parameter to Frontend/Popup constructors * Remove setChildrenSupported * Use event listener instead of function override * Update options order * Expand options and use object for clarity * Fix childrenSupported not being fully propagated
Diffstat (limited to 'ext/fg/js/popup-window.js')
-rw-r--r--ext/fg/js/popup-window.js11
1 files changed, 6 insertions, 5 deletions
diff --git a/ext/fg/js/popup-window.js b/ext/fg/js/popup-window.js
index 1365211c..3d707a9e 100644
--- a/ext/fg/js/popup-window.js
+++ b/ext/fg/js/popup-window.js
@@ -20,7 +20,12 @@
*/
class PopupWindow extends EventDispatcher {
- constructor(id, depth, frameId, ownerFrameId) {
+ constructor({
+ id,
+ depth,
+ frameId,
+ ownerFrameId
+ }) {
super();
this._id = id;
this._depth = depth;
@@ -123,10 +128,6 @@ class PopupWindow extends EventDispatcher {
// NOP
}
- async setChildrenSupported(_value) {
- // NOP
- }
-
getFrameRect() {
return new DOMRect(0, 0, 0, 0);
}