Popup setup refactoring (#1054)

* Pass childrenSupported as a parameter to Frontend/Popup constructors

* Remove setChildrenSupported

* Use event listener instead of function override

* Update options order

* Expand options and use object for clarity

* Fix childrenSupported not being fully propagated

1 files changed, 7 insertions, 5 deletions

diff --git a/ext/fg/js/popup-proxy.js b/ext/fg/js/popup-proxy.js
index 26659672..26dce0d1 100644
--- a/ext/fg/js/popup-proxy.js
+++ b/ext/fg/js/popup-proxy.js
@@ -20,7 +20,13 @@
  */
 
 class PopupProxy extends EventDispatcher {
-    constructor(id, depth, frameId, ownerFrameId, frameOffsetForwarder=null) {
+    constructor({
+        id,
+        depth,
+        frameId,
+        ownerFrameId,
+        frameOffsetForwarder
+    }) {
         super();
         this._id = id;
         this._depth = depth;
@@ -139,10 +145,6 @@ class PopupProxy extends EventDispatcher {
         return this._invokeSafe('setCustomOuterCss', {id: this._id, css, useWebExtensionApi});
     }
 
-    setChildrenSupported(value) {
-        return this._invokeSafe('setChildrenSupported', {id: this._id, value});
-    }
-
     getFrameRect() {
         return new DOMRect(0, 0, 0, 0);
     }