diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2021-02-09 22:56:04 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-09 22:56:04 -0500 |
| commit | 166451b8f76224542b49c13cb27a258eb291f05e (patch) | |
| tree | 071438b28a04b0478586272038ea343ad4cad319 /ext/fg/js/popup-factory.js | |
| parent | 0f5fb804d03041b58813516721d897c4315dca8b (diff) | |
Improve popup window ownership (#1364)
* Update frameInformationGet to also return the tab ID
* Add tabId to Frontend
* Pass tabId/frameId to Display
* Pass ownership information using setContent
* Remove ownerFrameId for Popup classes
* Use frameId instead of ownerFrameId for screenshotting
* Use contentOrigin instead of owner
* Update _invokeContentOrigin implementation
Diffstat (limited to 'ext/fg/js/popup-factory.js')
| -rw-r--r-- | ext/fg/js/popup-factory.js | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/ext/fg/js/popup-factory.js b/ext/fg/js/popup-factory.js index 6960b254..7571d7ab 100644 --- a/ext/fg/js/popup-factory.js +++ b/ext/fg/js/popup-factory.js @@ -56,7 +56,6 @@ class PopupFactory { async getOrCreatePopup({ frameId=null, - ownerFrameId=null, id=null, parentPopupId=null, depth=null, @@ -103,8 +102,7 @@ class PopupFactory { const popup = new PopupWindow({ id, depth, - frameId: this._frameId, - ownerFrameId + frameId: this._frameId }); this._popups.set(id, popup); return popup; @@ -117,7 +115,6 @@ class PopupFactory { id, depth, frameId: this._frameId, - ownerFrameId, childrenSupported }); if (parent !== null) { @@ -139,14 +136,12 @@ class PopupFactory { id, parentPopupId, frameId, - ownerFrameId, childrenSupported })); const popup = new PopupProxy({ id, depth, frameId, - ownerFrameId, frameOffsetForwarder: useFrameOffsetForwarder ? this._frameOffsetForwarder : null }); this._popups.set(id, popup); |