aboutsummaryrefslogtreecommitdiff
path: root/ext/bg
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2020-06-22 19:26:59 -0400
committerGitHub <noreply@github.com>2020-06-22 19:26:59 -0400
commit65c41975a6dca0610c7dc4454ece9534f3636893 (patch)
tree76a3a3ae056d68577f05b34d4ed95cca1dd66e04 /ext/bg
parentf2991fb9ee8e83738b726eb558af992f4bb5d9dc (diff)
Secure popup frame url changes (#622)
* Throw error if options is not ready * Remove id * Change unsecurePopupFrameUrl to useSecurePopupFrameUrl
Diffstat (limited to 'ext/bg')
-rw-r--r--ext/bg/data/options-schema.json6
-rw-r--r--ext/bg/js/options.js2
-rw-r--r--ext/bg/settings.html2
3 files changed, 5 insertions, 5 deletions
diff --git a/ext/bg/data/options-schema.json b/ext/bg/data/options-schema.json
index 5885e036..f8791433 100644
--- a/ext/bg/data/options-schema.json
+++ b/ext/bg/data/options-schema.json
@@ -110,7 +110,7 @@
"showPitchAccentPositionNotation",
"showPitchAccentGraph",
"showIframePopupsInRootFrame",
- "unsecurePopupFrameUrl"
+ "useSecurePopupFrameUrl"
],
"properties": {
"enable": {
@@ -249,9 +249,9 @@
"type": "boolean",
"default": false
},
- "unsecurePopupFrameUrl": {
+ "useSecurePopupFrameUrl": {
"type": "boolean",
- "default": false
+ "default": true
}
}
},
diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js
index 170e4799..151c945b 100644
--- a/ext/bg/js/options.js
+++ b/ext/bg/js/options.js
@@ -177,7 +177,7 @@ function profileOptionsCreateDefaults() {
showPitchAccentPositionNotation: true,
showPitchAccentGraph: false,
showIframePopupsInRootFrame: false,
- unsecurePopupFrameUrl: false
+ useSecurePopupFrameUrl: true
},
audio: {
diff --git a/ext/bg/settings.html b/ext/bg/settings.html
index 77b61aef..4de70b7e 100644
--- a/ext/bg/settings.html
+++ b/ext/bg/settings.html
@@ -183,7 +183,7 @@
</div>
<div class="checkbox options-advanced">
- <label><input type="checkbox" id="show-iframe-popups-in-root-frame" data-setting="general.unsecurePopupFrameUrl"> Use unsecure popup frame URL</label>
+ <label><input type="checkbox" data-setting="general.useSecurePopupFrameUrl"> Use secure popup frame URL</label>
</div>
<div class="checkbox options-advanced">