Simplify collapseEmphaticOptions options (#1196)

1 files changed, 14 insertions, 10 deletions

diff --git a/ext/bg/js/translator.js b/ext/bg/js/translator.js
index c9cdf8e4..c23649e1 100644
--- a/ext/bg/js/translator.js
+++ b/ext/bg/js/translator.js
@@ -301,22 +301,13 @@ class Translator {
     }
 
     _getAllDeinflections(text, options) {
-        const collapseEmphaticOptions = [[false, false]];
-        switch (options.collapseEmphaticSequences) {
-            case 'true':
-                collapseEmphaticOptions.push([true, false]);
-                break;
-            case 'full':
-                collapseEmphaticOptions.push([true, false], [true, true]);
-                break;
-        }
         const textOptionVariantArray = [
             this._getTextOptionEntryVariants(options.convertHalfWidthCharacters),
             this._getTextOptionEntryVariants(options.convertNumericCharacters),
             this._getTextOptionEntryVariants(options.convertAlphabeticCharacters),
             this._getTextOptionEntryVariants(options.convertHiraganaToKatakana),
             this._getTextOptionEntryVariants(options.convertKatakanaToHiragana),
-            collapseEmphaticOptions
+            this._getCollapseEmphaticOptions(options)
         ];
 
         const jp = this._japaneseUtil;
@@ -875,6 +866,19 @@ class Translator {
         }
     }
 
+    _getCollapseEmphaticOptions(options) {
+        const collapseEmphaticOptions = [[false, false]];
+        switch (options.collapseEmphaticSequences) {
+            case 'true':
+                collapseEmphaticOptions.push([true, false]);
+                break;
+            case 'full':
+                collapseEmphaticOptions.push([true, false], [true, true]);
+                break;
+        }
+        return collapseEmphaticOptions;
+    }
+
     _getSecondarySearchDictionaryMap(enabledDictionaryMap) {
         const secondarySearchDictionaryMap = new Map();
         for (const [dictionary, details] of enabledDictionaryMap.entries()) {