aboutsummaryrefslogtreecommitdiff
path: root/ext/bg
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2020-09-13 13:25:03 -0400
committerGitHub <noreply@github.com>2020-09-13 13:25:03 -0400
commit621aa354e77a5f0e7825ff0ad7a66c41154f2511 (patch)
tree194717396918d27c0ebadc21e62a32714b27886f /ext/bg
parentb180ebc3bc5182712fe33e5af3bea64b06204dcc (diff)
Add scan dictionary type filters (#822)
* Add options for searchTerms and searchKanji * Add settings HTML * Add options to TextScanner * Update _search/_findDefinitions to include searchTerms/searchKanji args * Update _searchAtFromMouseMove args * Change argument structure for _searchAt * Use scanning options for searchTerms and searchKanji
Diffstat (limited to 'ext/bg')
-rw-r--r--ext/bg/data/options-schema.json20
-rw-r--r--ext/bg/js/options.js4
-rw-r--r--ext/bg/js/settings/scan-inputs-controller.js4
-rw-r--r--ext/bg/settings.html2
4 files changed, 25 insertions, 5 deletions
diff --git a/ext/bg/data/options-schema.json b/ext/bg/data/options-schema.json
index 0f310f6e..93dde1e0 100644
--- a/ext/bg/data/options-schema.json
+++ b/ext/bg/data/options-schema.json
@@ -352,7 +352,9 @@
"showAdvanced": false,
"scanOnPenHover": true,
"scanOnPenPress": true,
- "scanOnPenRelease": false
+ "scanOnPenRelease": false,
+ "searchTerms": true,
+ "searchKanji": true
}
},
{
@@ -367,7 +369,9 @@
"showAdvanced": false,
"scanOnPenHover": true,
"scanOnPenPress": true,
- "scanOnPenRelease": false
+ "scanOnPenRelease": false,
+ "searchTerms": true,
+ "searchKanji": true
}
}
],
@@ -415,7 +419,9 @@
"showAdvanced",
"scanOnPenHover",
"scanOnPenPress",
- "scanOnPenRelease"
+ "scanOnPenRelease",
+ "searchTerms",
+ "searchKanji"
],
"properties": {
"showAdvanced": {
@@ -433,6 +439,14 @@
"scanOnPenRelease": {
"type": "boolean",
"default": false
+ },
+ "searchTerms": {
+ "type": "boolean",
+ "default": true
+ },
+ "searchKanji": {
+ "type": "boolean",
+ "default": true
}
}
}
diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js
index 673666bb..ccb1f256 100644
--- a/ext/bg/js/options.js
+++ b/ext/bg/js/options.js
@@ -522,7 +522,9 @@ class OptionsUtil {
showAdvanced: false,
scanOnPenHover: true,
scanOnPenPress: true,
- scanOnPenRelease: false
+ scanOnPenRelease: false,
+ searchTerms: true,
+ searchKanji: true
});
for (const {options: profileOptions} of options.profiles) {
profileOptions.general.usePopupWindow = false;
diff --git a/ext/bg/js/settings/scan-inputs-controller.js b/ext/bg/js/settings/scan-inputs-controller.js
index 09decaf3..b6498d7c 100644
--- a/ext/bg/js/settings/scan-inputs-controller.js
+++ b/ext/bg/js/settings/scan-inputs-controller.js
@@ -101,7 +101,9 @@ class ScanInputsController {
showAdvanced: false,
scanOnPenHover: true,
scanOnPenPress: true,
- scanOnPenRelease: false
+ scanOnPenRelease: false,
+ searchTerms: true,
+ searchKanji: true
}
}]
}]);
diff --git a/ext/bg/settings.html b/ext/bg/settings.html
index cc209c8a..8eeda187 100644
--- a/ext/bg/settings.html
+++ b/ext/bg/settings.html
@@ -472,6 +472,8 @@
<div class="scan-input-prefix-cell" data-property="options"><div class="scan-input-prefix">Options</div></div>
<div class="scan-input-content-cell" data-property="options"><div class="scan-input-input-cell-inner">
<div class="scan-input-type-list-container form-control"><div>
+ <div><label class="scan-input-toggle"><input type="checkbox" class="scan-input-settings-checkbox" data-property="options.searchTerms"><span>Search for terms</span></label></div>
+ <div><label class="scan-input-toggle"><input type="checkbox" class="scan-input-settings-checkbox" data-property="options.searchKanji"><span>Search for kanji</span></label></div>
<div><label class="scan-input-toggle"><input type="checkbox" class="scan-input-settings-checkbox" data-property="options.scanOnPenHover"><span>Scan on pen hover</span></label></div>
<div><label class="scan-input-toggle"><input type="checkbox" class="scan-input-settings-checkbox" data-property="options.scanOnPenPress"><span>Scan on pen press</span></label></div>
<div><label class="scan-input-toggle"><input type="checkbox" class="scan-input-settings-checkbox" data-property="options.scanOnPenRelease"><span>Scan on pen release</span></label></div>